Skip to content

Load AI, JSON and unrecognized configuration settings content types from Azure App Configuration - #105

Merged
AndreuCodina merged 2 commits into
mainfrom
feature/load-json-and-unrecognized-content-type-app-configuration
Oct 9, 2026
Merged

AndreuCodina merged 2 commits into
mainfrom
feature/load-json-and-unrecognized-content-type-app-configuration

Conversation

@AndreuCodina

Copy link
Copy Markdown
Member

No description provided.

Copilot AI balanced review requested due to automatic review settings October 8, 2026 18:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Valid case-varied JSON and Key Vault media types can incorrectly fall through as raw values.

2 open findings
What changed in this PR

Extends Azure App Configuration to load JSON, AI, and unrecognized content types.

Changes:

  • Expands JSON settings into flattened nested keys.
  • Loads unrecognized content types as raw values.
  • Improves documentation and initializes Python in Rust tests.
File Description
README.md Documents JSON and AI settings.
python/​wirio_settings/​core/​settings_binder.py Clarifies model-binding behavior.
src/​azure/​app_configuration/​azure_app_configuration_settings_provider.rs Adds JSON parsing and raw-value fallback.
src/​core/​content_type.rs Adjusts profile parsing and adds AI coverage.
src/​core/​serde_parser.rs Documents structured-value flattening.
src/​core/​settings_path.rs Initializes Python in tests.
src/​core/​settings_provider.rs Initializes Python in tests.
src/​json_file/​json_file_settings_provider.rs Initializes Python in tests.
src/​setting_per_file/​setting_per_file_settings_provider.rs Initializes Python in tests.
src/​yaml_file/​yaml_file_settings_provider.rs Initializes Python in tests.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/core/content_type.rs Outdated
@codecov

codecov Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.73418% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ation/azure_app_configuration_settings_provider.rs 98.00% 0 Missing and 2 partials ⚠️

📢 Thoughts on this report? Let us know!

@AndreuCodina
AndreuCodina merged commit fcad290 into main Oct 9, 2026
85 checks passed
@AndreuCodina
AndreuCodina deleted the feature/load-json-and-unrecognized-content-type-app-configuration branch October 9, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants