Repository navigation
Add opt-in to load feature flags from Azure App Configuration - #107
Merged
Merged
Conversation
AndreuCodina
changed the title
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The constructor change breaks positional compatibility, and the documentation retains a nonfunctional feature-flag example.
3 open findings
What changed in this PR
Adds explicit opt-in loading for Azure App Configuration enhanced feature flags.
Changes:
- Adds and propagates
feature_flag_enabled=False. - Skips feature-flag retrieval unless enabled.
- Updates documentation and tests for opt-in behavior.
| File | Description |
|---|---|
src/azure/app_configuration/azure_app_configuration_settings_source.rs |
Adds the opt-in setting to the source. |
src/azure/app_configuration/azure_app_configuration_settings_provider.rs |
Conditionally loads feature flags. |
python/wirio_settings/settings_manager.py |
Exposes the option through the public manager API. |
python/wirio_settings/_wirio_settings/azure_app_configuration.pyi |
Updates the generated constructor signature. |
tests/test_settings_manager.py |
Verifies option forwarding. |
tests/test_integration.py |
Covers enabled and default-disabled behavior. |
README.md |
Documents feature-flag opt-in and snapshots. |
Makefile |
Runs the new integration scenario. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.