Skip to content

feat: experimental static import.meta.env #12105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Aug 13, 2025
Merged

feat: experimental static import.meta.env #12105

merged 13 commits into from
Aug 13, 2025

Conversation

florian-lefebvre
Copy link
Member

Description (required)

Documents experimental.staticImportMetaEnv

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 5.13. See astro PR #14173.

@netlify Netlify
Copy link

netlify bot commented Aug 1, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit f54c754
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/689b8af5fe977a0008b08958
😎 Deploy Preview https://deploy-preview-12105--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@florian-lefebvre florian-lefebvre mentioned this pull request Aug 1, 2025
Merged
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Aug 1, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/experimental-flags/raw-env-values.mdx Source removed, will stop being tracked.
en/reference/experimental-flags/static-import-meta-env.mdx Localization added, will be marked as complete.
fr/reference/experimental-flags/raw-env-values.mdx Localization removed, will be marked as missing.
ko/reference/experimental-flags/raw-env-values.mdx Localization removed, will be marked as missing.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Aug 1, 2025
@sarah11918 sarah11918 added this to the 5.13.0 milestone Aug 1, 2025
@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Aug 11, 2025
@florian-lefebvre florian-lefebvre marked this pull request as ready for review August 11, 2025 09:21
ArmandPhilippot
ArmandPhilippot approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clear to me! I only spotted a missing rename.

@louisescher
Copy link
Contributor

I think this looks good!

sarah11918
sarah11918 reviewed Aug 12, 2025
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, here's a draft! See what you think @florian-lefebvre !

sarah11918
sarah11918 reviewed Aug 12, 2025
View reviewed changes
src/content/docs/en/reference/experimental-flags/static-import-meta-env.mdx
<Since v="5.13.0" />
</p>

:::tip[Astro 6.0 preview]
Copy link
Member

@sarah11918 sarah11918 Aug 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was trying to think of some "tip" to distinguish "here's a new feature" from "this is a new default" because we have two kinds of experimental flags.

yanthomasdev
yanthomasdev reviewed Aug 12, 2025
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more nits from me.

@florian-lefebvre
Copy link
Member Author

LGTM!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Aug 12, 2025
@sarah11918 sarah11918 mentioned this pull request Aug 12, 2025
Merged
yanthomasdev
yanthomasdev approved these changes Aug 13, 2025
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@sarah11918 sarah11918 changed the base branch from main to 5.13.0 August 13, 2025 11:05
@sarah11918 sarah11918 merged commit a992ec1 into 5.13.0 Aug 13, 2025
6 checks passed
@sarah11918 sarah11918 deleted the feat/experimental-static-meta-env branch August 13, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@ArmandPhilippot ArmandPhilippot ArmandPhilippot approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
5.13.0
Development

Successfully merging this pull request may close these issues.
6 participants
@florian-lefebvre @astrobot-houston @louisescher @sarah11918 @ArmandPhilippot @yanthomasdev