-
-
Notifications
You must be signed in to change notification settings - Fork 833
feat(search): upgrade DocSearch to v4 #3346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 21 commits
3e8a040
c0d686e
575a24b
2b7f591
0d3149a
9074031
1a9e73d
8a18606
cdcdcf5
b7fd3e2
bd40d10
201142c
2747d40
73bd631
35eebb9
2163c21
335f2de
cd98524
2400723
9e50fb8
74ba3af
ca76fdb
e060e93
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@astrojs/starlight-docsearch': minor | ||
| --- | ||
|
|
||
| Upgrades the [DocSearch dependency](https://github.com/algolia/docsearch) to stable v4 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,6 +18,7 @@ | |
| "dependencies": { | ||
| "@astro-community/astro-embed-youtube": "^0.5.6", | ||
| "@astrojs/starlight": "workspace:*", | ||
| "@astrojs/starlight-docsearch": "workspace:*", | ||
|
Comment on lines
20
to
+21
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here as well. Replace it with the published versions in the future rather than
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we use workspace here because the package is local. We'll not need it, when we'll remove the top comment |
||
| "@lunariajs/core": "^0.1.1", | ||
| "@types/culori": "^2.1.1", | ||
| "astro": "^5.6.1", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would assume all of this would be removed later, right? Because the Starlight docs use the default search, Pagefind, by default.
This is just to remind you just in case you forget.