Skip to content

Conversation

@JusticeMatthew
Copy link
Contributor

Description

Implements the change discussed in #1321
Closes #1321

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2025

🦋 Changeset detected

Latest commit: 4244139

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 17, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 4244139
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/68f8b49eb72e2c0008a7d43a
😎 Deploy Preview https://deploy-preview-3491--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Oct 17, 2025
@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

delucis
delucis previously approved these changes Oct 18, 2025
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JusticeMatthew! I added a changeset and this looks good.

We’ll merge it when we’re ready for our next minor release!

@delucis delucis added the 🌟 minor Change that triggers a minor release label Oct 18, 2025
@delucis delucis added this to the v0.37 milestone Oct 18, 2025
@delucis delucis added the ✅ approved Pull requests that have been approved and are ready to merge when next cutting a release label Oct 18, 2025
Copy link
Contributor

@trueberryless trueberryless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little nitpick, otherwise looks superb! 🚀

Does this affect #1885 in any way? Could we close it or should we still take a look at that?

Co-authored-by: Felix Schneider <[email protected]>
@delucis
Copy link
Member

delucis commented Oct 22, 2025

Does this affect #1885 in any way? Could we close it or should we still take a look at that?

Good question. The intention of that PR still stands: that these styles maybe belong in the Markdown styles rather than the reset. But I honestly lost the context for it, so can’t remember whether we should do that or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✅ approved Pull requests that have been approved and are ready to merge when next cutting a release 🌟 core Changes to Starlight’s main package 🌟 minor Change that triggers a minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"overflow-wrap: anywhere" is problematic in table cell code blocks

5 participants