-
-
Notifications
You must be signed in to change notification settings - Fork 829
Fix: Update overflow property in reset.css #3491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Implementing the changes discussed in withastro#1321 Closes withastro#1321
Change overflow-wrap property to break-word
🦋 Changeset detectedLatest commit: 4244139 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hello! Thank you for opening your first PR to Starlight! ✨ Here’s what will happen next:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @JusticeMatthew! I added a changeset and this looks good.
We’ll merge it when we’re ready for our next minor release!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
little nitpick, otherwise looks superb! 🚀
Does this affect #1885 in any way? Could we close it or should we still take a look at that?
Co-authored-by: Felix Schneider <[email protected]>
Good question. The intention of that PR still stands: that these styles maybe belong in the Markdown styles rather than the reset. But I honestly lost the context for it, so can’t remember whether we should do that or not. |

Description
Implements the change discussed in #1321
Closes #1321