Skip to content

Feat/unstake all at once #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 16, 2025
+11 −2
Merged

Feat/unstake all at once #2584

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2fd1446
feat(validations): allow unstaking all the stake at once
aesedepece Jan 28, 2025
4a84eff
feat(data_requests): increase max witnesses on testnet and dev envs
aesedepece Jan 28, 2025
c3e9e93
feat(validations): guard "unstake-it-all" rule behind V2_1 guard
aesedepece Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions validations/src/validations.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1465,12 +1465,14 @@ pub fn validate_unstake_transaction<'a>(
min_stake_nanowits: u64,
unstake_delay: u64,
) -> Result<(u64, u32, Vec<&'a ValueTransferOutput>), anyhow::Error> {
if get_protocol_version(Some(epoch)) <= ProtocolVersion::V1_8 {
let protocol_version = get_protocol_version(Some(epoch));

if protocol_version <= ProtocolVersion::V1_8 {
return Err(TransactionError::NoUnstakeTransactionsAllowed.into());
}

// Check if is unstaking more than the total stake
let amount_to_unstake = ut_tx.body.value() + ut_tx.body.fee;
let mut amount_to_unstake = ut_tx.body.value() + ut_tx.body.fee;

let validator = ut_tx.body.operator;
let withdrawer = ut_tx.signature.public_key.pkh();
Expand Down Expand Up @@ -1515,6 +1517,13 @@ pub fn validate_unstake_transaction<'a>(
}
};

// Introduced in V2_1:
// Apply a protocol-level "rule of convenience", where an amount to unstake of u64::MAX actually
// means "unstake all my stake".
if protocol_version >= ProtocolVersion::V2_1 && amount_to_unstake == u64::MAX {
amount_to_unstake = staked_amount;
}

// Allowed unstake actions:
// 1) Unstake the full balance (checked by the first condition)
// 2) Unstake an amount such that the remainder (the stake amount that is left over) is greater
Expand Down