fix(react-board): allow mutable react board renderable #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AviVahl
requested changes
Jan 8, 2025
| ...input, | ||
| render(target) { | ||
| const renderable = this as IReactBoard; |
There was a problem hiding this comment.
why the cast? why not type render to have this with a correct type?
https://www.typescriptlang.org/docs/handbook/2/functions.html#declaring-this-in-a-function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the react board renderable to be mutable.
The render of the react board renderable is now referenceing
thisinstead of adding an old reference into it's closure.