Skip to content

Commit

Permalink
feat!: use Node 22
Browse files Browse the repository at this point in the history
- add nvmrc and ensure CI uses that
- update to peaceiris/actions-gh-pages@v4
  • Loading branch information
AviVahl committed Jan 5, 2025
1 parent d885c31 commit 432262b
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 18 deletions.
7 changes: 3 additions & 4 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,14 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js 20
uses: actions/setup-node@v4
- uses: actions/setup-node@v4
with:
node-version: 20
node-version-file: .nvmrc
registry-url: "https://registry.npmjs.org/"
- run: npm ci
- run: npm run build
- name: Deploy to GitHub Pages
uses: peaceiris/actions-gh-pages@v3
uses: peaceiris/actions-gh-pages@v4
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
publish_dir: ./dist
9 changes: 4 additions & 5 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,17 @@ name: tests
on: [push, pull_request]
jobs:
tests:
name: node ${{ matrix.node-version }} / ${{ matrix.os }}
name: ${{ matrix.os }}
runs-on: ${{ matrix.os }}
timeout-minutes: 5
strategy:
fail-fast: false
matrix:
node-version: [20]
os: [ubuntu-latest, windows-latest, macOS-latest]
steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
node-version-file: .nvmrc
- run: npm ci
- run: npm test
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
22
16 changes: 8 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
},
"devDependencies": {
"@fal-works/esbuild-plugin-global-externals": "^2.1.2",
"@types/node": "20",
"@types/node": "22",
"@types/react": "^19.0.2",
"@types/react-dom": "^19.0.2",
"@types/wicg-file-system-access": "^2023.10.5",
Expand Down

0 comments on commit 432262b

Please sign in to comment.