Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): distinguish parent and child relations on a graph #2501

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

VladyslavG
Copy link
Contributor

@VladyslavG VladyslavG commented Jun 21, 2024

I had a task to refactor some fixtures in the Codux. I decided to use our feature graph for that and it was really useful.
However when viewing feature graph I noticed that all links - parent and child are highlighted in the same color. I could not understand looking at a graph where was my feature requested as a child. Take a look at this:

image

I hovered over file-assets and it is impossible to tell which related feature uses file-assets vs which is used by file-assets.

So I propose to use different colors for parent links vs child links. I used this approach personally in my abovementioned task and it helped me a lot! So I decided to create this PR, maybe it will help other people when playing with features

After applying my changes:
image

You can clearly see different colored lines and distinguish parent vs child relations.
If you don't like the suggested color, please feel free to fix it.

@VladyslavG VladyslavG requested a review from AviVahl June 21, 2024 05:55
@barak007
Copy link
Collaborator

have you tried to run yarn engine analyze ?
I think we should invest more there...maybe even move this graph to it.
my plan is to remove the original dashboard package in the feature.

@barak007
Copy link
Collaborator

@VladyslavG what was the motivation here? do you need better analysis?

@VladyslavG
Copy link
Contributor Author

yarn engine analyze

my motivation was to understand relationships between features visually without reading the code for each feature. And that graph (with my tweak) was very helpful.
yarn engine analyze doesn't help me to visualize feature dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants