fix: race condition when engine was not ready and terminate was called. #2567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoros
approved these changes
Sep 12, 2024
AviVahl
reviewed
Sep 12, 2024
| console.log('[${env.name}]: Terminating'); | ||
| return engine.shutdown(); | ||
| } catch (e) { | ||
| return; |
There was a problem hiding this comment.
would this not swallow shutdown errors we would like to see?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tests it's possible that the termination request was fired before main entry point was finished.
we used to only register to the termination event after it was finished and we missed the terminate event.
There is no test in this PR since there is a tech-debt to allow for such tests: #2569