fix: re-introduce prevSelectedId to change focus when selection changes
#1091
+19
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
along with recent functionality changes
alissawix
reviewed
Jan 16, 2025
packages/components/src/scroll-list/hooks/use-scroll-list-scroll-to-selected.ts
Outdated
Show resolved
Hide resolved
now it gets the id of the item last selected if there is no focus
|
@alissawix @PeterShershov Please inspect this commit: cd361a1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-introduce the anti-pattern of changing a state while in the rendering phase (unless a better way exists) to sync focus to selection changes.