Skip to content

Commit

Permalink
infra: use node16 moduleResolution
Browse files Browse the repository at this point in the history
- to support "exports" going forward
- downgraded chai types to match chai vesion. new resolution correctly detected it being an esm-only types being imported from our commonjs repository
  • Loading branch information
AviVahl committed Jan 3, 2025
1 parent b1cb347 commit 7f6f810
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 18 deletions.
18 changes: 4 additions & 14 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"devDependencies": {
"@ts-tools/node": "^6.1.0",
"@types/chai": "^5.0.1",
"@types/chai": "^4.3.20",
"@types/mocha": "^10.0.10",
"@types/node": "22",
"@webref/css": "~6.12.15",
Expand Down
5 changes: 4 additions & 1 deletion pleb.config.mjs
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
export default {
pinnedPackages: [{ name: 'chai', reason: 'esm only from v5' }],
pinnedPackages: [
{ name: 'chai', reason: 'esm only from v5' },
{ name: '@types/chai', reason: 'esm only from v5' },
],
};
4 changes: 2 additions & 2 deletions tsconfig.base.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@
// "moduleDetection": "auto", /* Control what method is used to detect module-format JS files. */

/* Modules */
"module": "commonjs", /* Specify what module code is generated. */
"module": "node16", /* Specify what module code is generated. */
// "rootDir": "./", /* Specify the root folder within your source files. */
"moduleResolution": "node", /* Specify how TypeScript looks up a file from a given module specifier. */
"moduleResolution": "node16", /* Specify how TypeScript looks up a file from a given module specifier. */
// "baseUrl": "./", /* Specify the base directory to resolve non-relative module names. */
// "paths": {}, /* Specify a set of entries that re-map imports to additional lookup locations. */
// "rootDirs": [], /* Allow multiple folders to be treated as one when resolving modules. */
Expand Down

0 comments on commit 7f6f810

Please sign in to comment.