Fix allowance calculation which always return 0 in some circumstances. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indeed, when per is greater than rate, the division of rate by per returns 0 (in python 2.x) Import division solve the problem
|
I've also been impacted by this today, and tracked down the same problem. What a spooky coincidence 👻 I'm hoping to work around it in the meantime by making my values for |
|
Thanks guys - have merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Indeed, in the consume function from TokenBucket, when per is greater than rate, the division of rate by per returns 0 (in python 2.x)
Import division solves the problem