Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interface_android.go #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update interface_android.go #9

wants to merge 1 commit into from

Conversation

BieHDC
Copy link

@BieHDC BieHDC commented Dec 26, 2024

makes me happy, makes the compiler happy, everything works as expected, i refuse to elaborate anything, billions must compile without pain.

time to end this clownshow
@wlynxg
Copy link
Owner

wlynxg commented Dec 27, 2024

This code is to solve the problem golang/go#68082. However, since 1.23, go has disabled //go:linkname by default, so you must add the -checklinkname=0 parameter when compiling. This is really painful. So do you have a better solution to avoid compile warnings?

@BieHDC
Copy link
Author

BieHDC commented Dec 27, 2024

This code is to solve the problem golang/go#68082. However, since 1.23, go has disabled //go:linkname by default, so you must add the -checklinkname=0 parameter when compiling. This is really painful. So do you have a better solution to avoid compile warnings?

I didnt get any. All i did was this change and whatever fyne package does gives me an apk and said application works. I can link it here when i publish it.

@BieHDC
Copy link
Author

BieHDC commented Dec 27, 2024

Hello friend, sorry for being a little spicy yesterday. It was late at night and this was the 2nd workaround that hit the project. Which btw thanks a lot for providing this package, otherwise i would have cut the feature.
As promised here is the example.
Here i am linking against this pr branch, here how it is compiled for android and where i use the code.
Here is the apk if you want to test it.

@wlynxg
Copy link
Owner

wlynxg commented Jan 3, 2025

Hello friend, thank you very much for your example. I also have the trouble of having to add additional compilation parameters when using it.
Since the package previously provided the ability to handle the golang/go#68082 issue, in order to maintain forward compatibility, it is not easy to remove this ability for the time being. I am very sorry for this.
If there is a more elegant solution, I will apply it to this repository as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants