Skip to content

Conversation

@maschu09
Copy link

@maschu09 maschu09 commented Jun 14, 2016

ttl/defchem.ttl Outdated
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
@prefix skos: <http://www.w3.org/2004/02/skos/core#> .
@prefix owl: <http://www.w3.org/2002/07/owl#> .
@prefix defchem: <https://ontology.geodab.eu/def/chemistry/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to use a wmo definition, i suggest

<https://test.wmocodes.info/def/chemistry/>

@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
@prefix skos: <http://www.w3.org/2004/02/skos/core#> .
@prefix owl: <http://www.w3.org/2002/07/owl#> .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add

@prefix ldp:   <http://www.w3.org/ns/ldp#> .

added prefix ldp
@prefix skos: <http://www.w3.org/2004/02/skos/core#> .
@prefix owl: <http://www.w3.org/2002/07/owl#> .
@prefix ldp: <http://www.w3.org/ns/ldp#> .

Copy link
Member

@marqh marqh Jun 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@prefix reg:   <http://purl.org/linked-data/registry#> .

@marqh
Copy link
Member

marqh commented Jun 14, 2016

uploaded version of defchem.ttl at
https://test.wmocodes.info/def/chemistry

  • file has been changed since this, please reload

@maschu09
Copy link
Author

@marqh Please enjoy your weekend and look at new files early next week ;-)

@maschu09
Copy link
Author

@marqh I uploaded atmospheric_chemical_species.ttl with all the corrections we discussed yesterday. Note that I added "atmospheric" to the file name, because I realized that scientists from other disciplines (e.g. minearology) might need a very different set of species, and I don't believe it will be possible to create and maintain one list for everyone. It may therefore be better to establish separate lists for different disciplines and link the contents via exactMatch or similarMatch relations. Please try to upload this to common/atmospheric-chemical-species.

@maschu09
Copy link
Author

@marqh A general question: while preparing the Excel "master" spreadsheet I thought that this information would be much better maintained in a database. But in my understanding the registry is already a database, is it not? So, woul dit actually make sense to set up our own "master" database here, or wouldn't it be a better workflow if - once we have populated the registry - we would have tools to expand, edit, or deprecate the registry's content. I would defintively like to get away from spreadsheets, but the fewer systems are involved the less chances there are for inconcistencies.

@maschu09
Copy link
Author

maschu09 commented Jun 16, 2016

@marqh OK - done it! wmdObservedVariable.ttl also ready for upload from my perspective. Should also go into common.

@marqh
Copy link
Member

marqh commented Jun 29, 2016

Hello @maschu09

line 391 in
atmospheric_chemical_species.ttl
https://github.com/maschu09/code-manuals/blob/57fd51755fbcf991e8feb3a19c01aad943f89492/ttl/atmospheric_chemical_species.ttl#L391
(and many other lines)

contain an element of the form:

 skos:closeMatch gemet:concept?cp=623 ;

The ?, %, - and = are special characters in TTL, and must be 'escaped', as per
https://www.w3.org/TR/turtle/#sec-grammar
(I think)

So,

 skos:closeMatch gemet:concept\?cp\=623 ;

etc.

the nist URIs are failing to parse, I'm trying to unpick the special characters in these but I can't get to the bottom of the problem

Is it easy for you to reverse the implementation of the nist prefix and include all of these as full URIs enclosed in <> then I think this might be a simpler approach. It seems regressive to me, but I think it may be pragmatic
i think the same is true of the gmet and ofmpub ones

although the prefixing is a useful encoding, it turns out in these cases it is causing more problems than it solves.
As it was my suggestion, I can only apologise for this

@marqh
Copy link
Member

marqh commented Jun 29, 2016

I have done a local search and replace and uploaded content to:
https://test.wmocodes.info/common/chemical-species

please let me know when you have altered your creation process to handle these properly

@marqh
Copy link
Member

marqh commented Jun 29, 2016

wmdsObservedVariable requires

@prefix defchem: <http://codes.wmo.int/def/defchem/> .
@prefix medium: <http://codes.wmo.int/common/medium/> .
@prefix chemical-species: <http://codes.wmo.int/common/chemical-species/> .

at the top

additionally, a number of the chemical species identifiers have commas in their name, which needs to be 'escaped' in ttl
e.g. line 2968

        defchem:chemical-species chemical-species:1\,2-dichlorotetrafluoroethane ;

maschu09 added 3 commits June 30, 2016 11:26
fixing syntactic errors (escape commata) and add prefixes for chemcial-species and medium
File produced again from excel spreadsheet; replaced prefixes for foreign thesauri with explicit web links.
@maschu09
Copy link
Author

@marqh I have uploaded two new ttl files for atmospheric_chemical_species.ttl and wmdObservedVariables.ttl in which the issues you raised have been fixed.

@marqh
Copy link
Member

marqh commented Jul 12, 2016

@marqh I have uploaded two new ttl files for atmospheric_chemical_species.ttl and wmdObservedVariables.ttl in which the issues you raised have been fixed.

I can confirm that these files now parse and have been uploaded to
http://test.wmocodes.info/common/chemical-species
and
http://test.wmocodes.info/common/wmdsObservedVariable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants