Add WOLFSSL_OLD_OID_SUM for nginx and socat builds for compatibility #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
padelsbach
force-pushed
the
wp_old_oid_flag_alt
branch
2 times, most recently
from
a8cdeae to
3f4d80f
Compare
padelsbach
commented
May 8, 2025
scripts/utils-wolfssl.sh
Outdated
| @@ -119,7 +119,7 @@ install_wolfssl() { | |||
| cd XXX-fips-test | |||
| fi | |||
|
|
|||
| ./configure ${CONF_ARGS} ${WOLFSSL_CONFIG_OPTS} CFLAGS="${WOLFSSL_CONFIG_CFLAGS}" >>$LOG_FILE 2>&1 | |||
| ./configure ${CONF_ARGS} ${WOLFSSL_CONFIG_OPTS} CFLAGS="${WOLFSSL_CONFIG_CFLAGS} ${WOLFSSL_CONFIG_CFLAGS_EXTRA}" >>$LOG_FILE 2>&1 | |||
There was a problem hiding this comment.
When $WOLFSSL_CONFIG_CFLAGS is used, it replaces the entire string. To add to the flags, I created this new variable.
padelsbach
force-pushed
the
wp_old_oid_flag_alt
branch
6 times, most recently
from
304d577 to
2936447
Compare
padelsbach
force-pushed
the
wp_old_oid_flag_alt
branch
from
2936447 to
5b4099b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate approach of PR #131
Fixes nginx and socat github action failures.
Related PR on WolfSSL is here wolfSSL/wolfssl#8655, commit is 1e3718ea7b92b04d9d81dbf8e7d6032ca0a904cb.