Repository navigation
Fix event label sizing and event config update validation - #109
aidangarske wants to merge 14 commits into
Conversation
…kup buffer for a maximum-length label and its terminator
…ngth event labels across the event lookup APIs
…utput only after the event is inserted
…nfiguration in event config updates
…out changes in event config updates once routes use the event
…as its own auxiliary event
… mark when an event stops being any event's auxiliary event
… serving as an auxiliary event cannot have its own auxiliary event
…parent event cannot be set as an auxiliary event
…ault event priority and test that omitted priority behaves as zero
…-length event label in the JSON loader
…output only after the action is inserted
…use and held references as route ownership in the event layout guard
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #109
Scan targets checked: wolfsentry-src, wolfsentry-bugs
Not reviewed (no scan target covers them): doc/json_configuration.md, src/wolfsentry_internal.h
Coverage: 2 of 5 in-scope changed file(s) opened by the reviewer; not opened: src/actions.c, tests/unittests.c, wolfsentry/wolfsentry.h
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Review tier: Lite
…d subevent mark from the aux owner count
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #109
Scan targets checked: wolfsentry-src, wolfsentry-bugs
Not reviewed (no scan target covers them): doc/json_configuration.md, src/wolfsentry_internal.h
Coverage: 1 of 2 in-scope changed file(s) opened by the reviewer; not opened: tests/unittests.c
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
Fenrir's latest completed scan found no issues; clearing the prior automated change request.
F-5558- cce34df - The event lookup buffer is now sized for a maximum-length label and its terminator.F-13883- 22e0de4 - New tests cover maximum-length event labels across the event lookup APIs.F-8758- b4334c0 - The event id output is now set only after the event is inserted.F-11606- 90490ea - Event config updates now reject a NULL configuration.F-11619- 373aacf - Event config updates now reject route layout changes once routes use the event.F-11602- ab8fc1e - An event can no longer be set as its own auxiliary event.F-5566- f0da0e6 - The subevent mark is now cleared when an event stops being any event's auxiliary event.F-3870- a03c1d4 - A new test covers an auxiliary event being barred from having its own auxiliary event.F-3871- 819e109 - A new test covers a route parent event being barred from becoming an auxiliary event.F-10506- 386ace4 - The default event priority is now documented, and a test covers an omitted priority behaving as zero.F-13883- c755dec - The JSON loader now accepts a maximum-length event label.F-8758- 2fe8155 - The action id output is now set only after the action is inserted.F-11619- 593be8a - The event layout guard now treats auxiliary event use and held references as route ownership.