Repository navigation
Add route flag validation and purge limit tests - #110
Open
aidangarske wants to merge 8 commits into
Open
aidangarske wants to merge 8 commits into
aidangarske wants to merge 8 commits into
Conversation
…sert rejects a route with no direction flag
…sert by exports rejects a route with no direction flag
…ag validation rejects inconsistent wildcard combinations
…ag update rejects setting both penaltybox and greenlist
…ag update rejects changes to immutable flags on an inserted route
…ag update rejects changes to internal table flags
… the purgeable route limit purges excess stale routes
…st addresses through a full-width buffer for C89 builds
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #110
Scan targets checked: wolfsentry-bugs
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-2846- 91dea1f - A new test covers route insert rejecting a route with no direction flag.F-2848- 26ec3d5 - A new test covers route insert by exports rejecting a route with no direction flag.F-3440- 3d47d24 - A new test covers route flag validation rejecting inconsistent wildcard combinations.F-2842- 6bf4bdb - A new test covers route flag update rejecting penaltybox and greenlist together.F-2844- 2c8a8ee - A new test covers route flag update rejecting changes to immutable flags on an inserted route.F-2847- 4154573 - A new test covers route flag update rejecting changes to internal table flags.F-4563- 2da7574 - A new test covers lowering the purgeable route limit purging the excess stale routes.