Repository navigation
Fix head and tail link setup in list insert - #89
Open
aidangarske wants to merge 3 commits into
Open
aidangarske wants to merge 3 commits into
aidangarske wants to merge 3 commits into
Conversation
…ntry prev pointer in list insert before helper
…ry next pointer in list insert after helper
…ests to call the inline list primitives under -Winline
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #89
Scan targets checked: wolfsentry-bugs
Not reviewed (no scan target covers them): src/wolfsentry_ll.h
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-15467- 388b3c0 - List insert now clears the prev pointer of a new head entry before calling the helper, so a stale back link is never left behind.F-15466- 2087847 - List insert now sets the next pointer of a new tail entry after the helper runs, so the tail is always terminated.