Skip to content

Zendesk Coverity changes #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2025
Merged

Zendesk Coverity changes #822

merged 3 commits into from
Jul 23, 2025

Conversation

rlm2002
Copy link

@rlm2002 rlm2002 commented Jul 21, 2025 •
edited
Loading

Adds NULL checks to clear Coverity issues reported in ZD#20212.

  • Dereference before NULL check
    • check ssh->ctx != NULL before dereferencing in GetAllowedAuth() (wolfSSH Project 572900)
  • Dereference after NULL check
    • Add additional NULL checks as SendUserAuthKeyboardRequest() does not return immediately if ssh or authData are NULL (wolfSSH Project CI 572871 and CI 572874)
    • AlgoListSz() returns 0 if param is NULL (wolfSSH Project 572893)

@rlm2002 rlm2002 assigned rlm2002 and wolfSSL-Bot and unassigned rlm2002 Jul 21, 2025
dgarske
dgarske previously approved these changes Jul 22, 2025
View reviewed changes
@ejohnstown ejohnstown self-requested a review July 22, 2025 16:55
ejohnstown
ejohnstown requested changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@ejohnstown ejohnstown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues 572871 and 572874 are still present. I think it found two issues each in the areas you fixed, but you only fixed one of the issues.

@rlm2002 rlm2002 requested a review from ejohnstown July 22, 2025 20:16
add ret checks for WS_SUCCESS to prevent dereference after null check
4796e34 
NULL check before dereferencing authData

additional checks

formatting changes

adjust return values
@ejohnstown ejohnstown merged commit 93ddf8f into wolfSSL:master Jul 23, 2025
93 checks passed
@rlm2002 rlm2002 deleted the zd20212 branch July 23, 2025 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejohnstown ejohnstown ejohnstown approved these changes

@dgarske dgarske dgarske left review comments

Assignees

@ejohnstown ejohnstown

@JacobBarthelmeh JacobBarthelmeh

@wolfSSL-Bot wolfSSL-Bot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rlm2002 @ejohnstown @dgarske @JacobBarthelmeh @wolfSSL-Bot