Replace XMEMCMP with ConstantCompare when validating secure renegotiation (SCR) verify data#9899
Merged
douzzer merged 2 commits intowolfSSL:masterfrom Mar 7, 2026
Merged
Conversation
…otiation (SCR) verify data F-16
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SCR (secure renegotiation) verify-data validation to use a constant-time comparison routine instead of XMEMCMP.
Changes:
- Replaced
XMEMCMPwithConstantComparefor SCR client verify-data validation. - Replaced
XMEMCMPwithConstantComparefor SCR client+server verify-data validation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
douzzer
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-16