Address deprecation warnings for 8.5#458
Open
zhongruige wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to eliminate (and prevent regressions of) PHP 8.5 runtime deprecations by removing deprecated calls (curl_close(), Reflection*::setAccessible()), replacing reflection-based access with proper accessors, and adding unit tests to guard against reintroduction.
Changes:
- Replace reflection-based option “mode” extraction with public-API reconstruction in
OptionReuseTrait. - Stop calling deprecated APIs (
curl_close(),setAccessible()), usingunset()/accessors instead. - Add unit tests: a static deprecation scan for
src/, and behavior tests forOptionReuseTrait.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/unit/Php85DeprecationGuardTest.php | Adds a static scan test to detect PHP 8.5-deprecated calls in src/. |
| src/tests/unit/OptionReuseTraitTest.php | Adds unit coverage to ensure reused Symfony Console options keep identical behavior. |
| src/tests/unit/data/pull-sync-json.php | Removes curl_close() usage in test data fetch helper. |
| src/tests/unit/compare_snapshots.php | Removes curl_close() usage in local snapshot comparison helper. |
| src/src/RequestBuilder.php | Replaces curl_close() with unset() to avoid PHP 8.5 deprecation warnings. |
| src/src/OptionReuseTrait.php | Removes reflection and reconstructs InputOption mode from public methods. |
| src/src/Environment/EnvUpChecker.php | Replaces curl_close() with unset() to avoid PHP 8.5 deprecation warnings. |
| src/src/Environment/Environments/Environment.php | Adds a get_docker() accessor to replace reflection-based access. |
| src/src/Commands/Environment/ExtensionSummary.php | Switches from reflection to get_docker() accessor for Docker access. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses deprecation warnings for PHP 8.5