Skip to content

Address deprecation warnings for 8.5#458

Open
zhongruige wants to merge 3 commits into
trunkfrom
qit-978-fix-for-deprecated-warnings-on-php-85-in-qit-cli
Open

Address deprecation warnings for 8.5#458
zhongruige wants to merge 3 commits into
trunkfrom
qit-978-fix-for-deprecated-warnings-on-php-85-in-qit-cli

Conversation

@zhongruige

Copy link
Copy Markdown
Collaborator

This PR addresses deprecation warnings for PHP 8.5

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to eliminate (and prevent regressions of) PHP 8.5 runtime deprecations by removing deprecated calls (curl_close(), Reflection*::setAccessible()), replacing reflection-based access with proper accessors, and adding unit tests to guard against reintroduction.

Changes:

  • Replace reflection-based option “mode” extraction with public-API reconstruction in OptionReuseTrait.
  • Stop calling deprecated APIs (curl_close(), setAccessible()), using unset()/accessors instead.
  • Add unit tests: a static deprecation scan for src/, and behavior tests for OptionReuseTrait.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/tests/unit/Php85DeprecationGuardTest.php Adds a static scan test to detect PHP 8.5-deprecated calls in src/.
src/tests/unit/OptionReuseTraitTest.php Adds unit coverage to ensure reused Symfony Console options keep identical behavior.
src/tests/unit/data/pull-sync-json.php Removes curl_close() usage in test data fetch helper.
src/tests/unit/compare_snapshots.php Removes curl_close() usage in local snapshot comparison helper.
src/src/RequestBuilder.php Replaces curl_close() with unset() to avoid PHP 8.5 deprecation warnings.
src/src/OptionReuseTrait.php Removes reflection and reconstructs InputOption mode from public methods.
src/src/Environment/EnvUpChecker.php Replaces curl_close() with unset() to avoid PHP 8.5 deprecation warnings.
src/src/Environment/Environments/Environment.php Adds a get_docker() accessor to replace reflection-based access.
src/src/Commands/Environment/ExtensionSummary.php Switches from reflection to get_docker() accessor for Docker access.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/src/RequestBuilder.php Outdated
Comment thread src/tests/unit/Php85DeprecationGuardTest.php
Comment thread src/tests/unit/OptionReuseTraitTest.php Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants