-
Notifications
You must be signed in to change notification settings - Fork 131
[Shipping labels] Refactor purchased screen preview #13909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Shipping labels] Refactor purchased screen preview #13909
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for cleaning this up @irfano.
Just one minor suggestion: WDYT about renaming WooShippingLabelPurchasedWithBottomSheetScreen
to WooShippingLabelPurchasedScreen
just to be consistent with the other Composable files where we have the root file accepting the viewModel
and the overload with the data models for the preview? Feel free to ignore this suggestion 🙂.
Thank you for your review. I renamed |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #13909 +/- ##
============================================
- Coverage 38.32% 38.32% -0.01%
+ Complexity 9407 9406 -1
============================================
Files 2098 2098
Lines 115971 115971
Branches 14831 14831
============================================
- Hits 44450 44449 -1
Misses 67477 67477
- Partials 4044 4045 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes: WOOMOB-266
Description
This PR removes an unnecessary composable that was only used for preview. The removed composable (
WooShippingLabelPurchasedScreen
) was the duplicate of the one used in production.Steps to reproduce
This shouldn’t affect production. Reviewing the composable preview should be sufficient.
The tests that have been performed
Compared the previews shown below.
Images/gif
RELEASE-NOTES.txt
if necessary. Use the "[Internal]" label for non-user-facing changes.Reviewer (or Author, in the case of optional code reviews):
Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement: