Skip to content

Conversation

hichamboushaba
Copy link
Member

@hichamboushaba hichamboushaba commented Sep 18, 2025

Closes WOOMOB-1364

Description

This PR adds logic to hide the POS tab for CIAB sites.

Steps to reproduce

  1. Use a tablet.
  2. Sign in using a CIAB site (Check this for creating a demo site pdpAdu-29A-p2)
  3. Confirm the POS tab is now shown.
  4. Switch to a different site (site that supports POS, it should have US or UK country, and shouldn't have disabled the POS feature explicitly)
  5. Confirm the POS tab is shown.

Testing information

  • Confirm POS is now shown for CIAB sites.
  • Confirm there is no impact for other sites.

The tests that have been performed

The above.

Images/gif

CIAB site Non-CIAB site
Screenshot_20250918_151425 Screenshot_20250918_145001

Remark: The bookings tab is shown for the non-CIAB site in the above screenshot, this is just temporary, later the tab would be hidden for non-CIAB sites.

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@hichamboushaba hichamboushaba added this to the 23.3 milestone Sep 18, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Sep 18, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.3. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App Name WooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commit153cd09
Direct Downloadwoocommerce-wear-prototype-build-pr14634-153cd09.apk

@hichamboushaba hichamboushaba changed the title Issue/woomob 1364 ciab hide pos [CIAB] Hide POS Sep 18, 2025
@wpmobilebot
Copy link
Collaborator

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App Name WooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commit153cd09
Direct Downloadwoocommerce-prototype-build-pr14634-153cd09.apk

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.49%. Comparing base (deb6971) to head (153cd09).
⚠️ Report is 2 commits behind head on trunk.

Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #14634   +/-   ##
=========================================
  Coverage     38.48%   38.49%           
- Complexity     9767     9768    +1     
=========================================
  Files          2066     2066           
  Lines        115464   115470    +6     
  Branches      15379    15380    +1     
=========================================
+ Hits          44440    44447    +7     
  Misses        66902    66902           
+ Partials       4122     4121    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hichamboushaba hichamboushaba marked this pull request as ready for review September 18, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants