Skip to content

Conversation

@wzieba
Copy link
Contributor

@wzieba wzieba commented Nov 6, 2025

Closes: AINFRA-1365: Fix or remove file-based cache in Encrypted Logging

Description

This PR bumps Encrypted Logging to the version that doesn't use Volley anymore. A simplified solution, without a deprecated networking framework and without any cache, might contribute to lowering the number of ANR errors.

See applied change at: Automattic/EncryptedLogging#30

Test Steps

  1. Make sure your secrets are up to date, bundle exec fastlane run configure_apply
  2. Open the app
  3. Log in (I usually use https://jurassic.ninja/ and uncheck Jetpack and check WooCommerce)
  4. Go to settings, "Developer Options"
  5. Tap on "Send Sentry Report"
  6. Open Sentry, look for "Test Sentry report from Developer Options" report associated with your account (probably select "Latest")
  7. Copy UUID from "Additional Data" section
  8. Paste in to Encrypted Logs (can be found on MC > Tools)
  9. See that logs are present

Images/gif

  • I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

@dangermattic
Copy link
Collaborator

dangermattic commented Nov 6, 2025

1 Warning
⚠️ This PR is assigned to the milestone 23.7. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 6, 2025

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
App NameWooCommerce-Wear Android
Platform⌚️ Wear OS
FlavorJalapeno
Build TypeDebug
Commitab9b318
Direct Downloadwoocommerce-wear-prototype-build-pr14917-ab9b318.apk

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 6, 2025

Project dependencies changes

list
! Upgraded Dependencies
com.automattic:encryptedlogging:1.1.2, (changed from 1.1.1)
tree
-\--- com.automattic:encryptedlogging:1.1.1
-     +--- androidx.core:core-ktx:1.16.0 -> 1.17.0 (*)
-     +--- androidx.appcompat:appcompat:1.7.1 (*)
-     +--- androidx.room:room-runtime:2.7.2 -> 2.8.3 (*)
-     +--- androidx.room:room-ktx:2.7.2 -> 2.8.3 (*)
-     +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.10.2 (*)
-     +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
-     +--- com.android.volley:volley:1.2.1
-     +--- com.goterl:lazysodium-android:5.2.0
-     +--- net.java.dev.jna:jna:5.17.0
-     \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)
+\--- com.automattic:encryptedlogging:1.1.2
+     +--- androidx.core:core-ktx:1.16.0 -> 1.17.0 (*)
+     +--- androidx.appcompat:appcompat:1.7.1 (*)
+     +--- androidx.room:room-runtime:2.7.2 -> 2.8.3 (*)
+     +--- androidx.room:room-ktx:2.7.2 -> 2.8.3 (*)
+     +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.10.2 (*)
+     +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
+     +--- com.goterl:lazysodium-android:5.2.0
+     +--- net.java.dev.jna:jna:5.17.0
+     \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Nov 6, 2025

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

App NameWooCommerce Android
Platform📱 Mobile
FlavorJalapeno
Build TypeDebug
Commitab9b318
Direct Downloadwoocommerce-prototype-build-pr14917-ab9b318.apk

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.31%. Comparing base (ad23678) to head (ab9b318).
⚠️ Report is 62 commits behind head on trunk.

Files with missing lines Patch % Lines
...d/ui/prefs/developer/DeveloperOptionsRepository.kt 0.00% 7 Missing ⚠️
...id/ui/prefs/developer/DeveloperOptionsViewModel.kt 64.28% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##              trunk   #14917   +/-   ##
=========================================
  Coverage     38.30%   38.31%           
- Complexity    10129    10131    +2     
=========================================
  Files          2142     2142           
  Lines        121210   121230   +20     
  Branches      16629    16629           
=========================================
+ Hits          46435    46448   +13     
- Misses        70049    70058    +9     
+ Partials       4726     4724    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wzieba wzieba marked this pull request as ready for review November 12, 2025 08:16
@wzieba wzieba requested a review from a team as a code owner November 12, 2025 08:16
@wzieba wzieba requested review from irfano and removed request for a team November 12, 2025 08:16
@wzieba wzieba added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Nov 12, 2025
@wzieba wzieba added this to the 23.7 milestone Nov 12, 2025
@irfano irfano self-assigned this Nov 14, 2025
Copy link
Contributor

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix on the library and for upgrading it here. I hope it will reduce ANRs 🤞🏻
I verified that Sentry reporting is still working. 👍🏻 LGTM!

@irfano irfano merged commit 6020876 into trunk Nov 14, 2025
22 of 23 checks passed
@irfano irfano deleted the encrypted-logging-volley-fix branch November 14, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants