-
Notifications
You must be signed in to change notification settings - Fork 135
Bump Encrypted Logging to the version without Volley #14917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
Project dependencies changeslist! Upgraded Dependencies
com.automattic:encryptedlogging:1.1.2, (changed from 1.1.1)tree-\--- com.automattic:encryptedlogging:1.1.1
- +--- androidx.core:core-ktx:1.16.0 -> 1.17.0 (*)
- +--- androidx.appcompat:appcompat:1.7.1 (*)
- +--- androidx.room:room-runtime:2.7.2 -> 2.8.3 (*)
- +--- androidx.room:room-ktx:2.7.2 -> 2.8.3 (*)
- +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.10.2 (*)
- +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
- +--- com.android.volley:volley:1.2.1
- +--- com.goterl:lazysodium-android:5.2.0
- +--- net.java.dev.jna:jna:5.17.0
- \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)
+\--- com.automattic:encryptedlogging:1.1.2
+ +--- androidx.core:core-ktx:1.16.0 -> 1.17.0 (*)
+ +--- androidx.appcompat:appcompat:1.7.1 (*)
+ +--- androidx.room:room-runtime:2.7.2 -> 2.8.3 (*)
+ +--- androidx.room:room-ktx:2.7.2 -> 2.8.3 (*)
+ +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.10.2 (*)
+ +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
+ +--- com.goterl:lazysodium-android:5.2.0
+ +--- net.java.dev.jna:jna:5.17.0
+ \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*) |
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #14917 +/- ##
=========================================
Coverage 38.30% 38.31%
- Complexity 10129 10131 +2
=========================================
Files 2142 2142
Lines 121210 121230 +20
Branches 16629 16629
=========================================
+ Hits 46435 46448 +13
- Misses 70049 70058 +9
+ Partials 4726 4724 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
irfano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fix on the library and for upgrading it here. I hope it will reduce ANRs 🤞🏻
I verified that Sentry reporting is still working. 👍🏻 LGTM!
Closes: AINFRA-1365: Fix or remove file-based cache in Encrypted Logging
Description
This PR bumps Encrypted Logging to the version that doesn't use Volley anymore. A simplified solution, without a deprecated networking framework and without any cache, might contribute to lowering the number of ANR errors.
See applied change at: Automattic/EncryptedLogging#30
Test Steps
bundle exec fastlane run configure_applyImages/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.