Skip to content

Fix PHPCS deprecation warnings and update obsolete ruleset directives #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eason9487 merged 3 commits into from
Aug 24, 2026
+5 −12
Merged

Fix PHPCS deprecation warnings and update obsolete ruleset directives #653

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ae420f
Fix deprecated PHPCS ruleset syntax
eason9487 Aug 24, 2026
b451cbf
Update renamed and obsolete PHPCS ruleset directives
eason9487 Aug 24, 2026
4d70984
Drop PHPCS rule references already provided by the WordPress standard
eason9487 Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions phpcs.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<description>Generally-applicable sniffs for WordPress plugins</description>

<!-- Set the minimum WP version -->
<config name="minimum_supported_wp_version" value="7.0"/>
<config name="minimum_wp_version" value="7.0"/>

<rule ref="WordPress">
<!-- We don't require conforming to WP file naming -->
Expand All @@ -15,7 +15,6 @@
<exclude name="Squiz.Commenting.FunctionComment.MissingParamComment"/>
<exclude name="Squiz.Commenting.FunctionComment.ParamCommentFullStop"/>
<exclude name="Squiz.Commenting.InlineComment.InvalidEndChar"/>
<exclude name="Squiz.Commenting.LongConditionClosingComment"/>

<!-- No thanks -->
<exclude name="Universal.Operators.DisallowShortTernary"/>
Expand All @@ -35,29 +34,23 @@
</rule>

<!-- Include some other sniffs we want to enforce. -->
<rule ref="Generic.VersionControl.GitMergeConflict"/>
<rule ref="Generic.WhiteSpace.SpreadOperatorSpacingAfter"/>
<rule ref="PSR12.Classes.AnonClassDeclaration"/>
<rule ref="PSR12.Classes.ClassInstantiation"/>
<rule ref="PSR12.Files.ImportStatement"/>
<rule ref="PSR12.Functions.NullableTypeDeclaration"/>
<rule ref="PSR12.Functions.ReturnTypeDeclaration"/>
<rule ref="PSR12.Properties.ConstantVisibility"/>
<rule ref="PSR12.Traits.UseDeclaration"/>
<rule ref="Squiz.Classes">
<rule ref="Squiz.Classes.ClassDeclaration">
<exclude name="Squiz.Classes.ClassDeclaration.OpenBraceNewLine"/>
<exclude name="Squiz.Classes.ClassDeclaration.CloseBraceSameLine"/>
<exclude name="Squiz.Classes.ClassDeclaration.SpaceBeforeKeyword"/>
<exclude name="Squiz.Classes.ClassDeclaration.SpaceBeforeCloseBrace"/>
<exclude name="Squiz.Classes.ClassFileName.NoMatch"/>
<exclude name="Squiz.Classes.ValidClassName.NotCamelCaps"/>
</rule>
<rule ref="Squiz.WhiteSpace.FunctionOpeningBraceSpace"/>

<!-- Set the appropriate text domain. -->
<rule ref="WordPress.WP.I18n">
<properties>
<property name="text_domain" type="array" value="woocommerce-google-analytics-integration"/>
<property name="text_domain" type="array">
<element value="woocommerce-google-analytics-integration"/>
</property>
</properties>
</rule>

Expand Down