[Woo POS] Coupons: List - Enable Coupons - Wrap Up (Designer UI and Copy)

[staskus]

Description

A wrap-up of enabling coupons setting:

• Reload the list once the setting is enabled.
• Loading state
• Error handling if enabling fails
• Disable/hide the coupon creation button when coupons cannot be created (the looks will be refined with the header task)

Steps to reproduce

Prerequisites:

• Disable Enable the use of coupon codes in WooCommerce -> Settings
• Enable enableCouponsInPointOfSale feature flag

1. Open POS
2. Open Coupons
3. Confirm 'Coupons disabled' error is shown
4. Confirm '+' button for adding coupons is not visible
5. Turn off network connection
6. Tap 'Enable'
7. Confirm 'Coupons enabling' error is shown
8. Turn on network connection
9. Tap 'Retry'
10. Confirm coupon setting is enabled and list loaded

Testing information

Tested iPad Air 11 Inch M2 iOS 18.2

Screenshots

Enabling and loading coupons

enabling.and.loading.coupons.mp4

Error enabling coupons

error.enabling.coupons.mp4

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Reviewer (or Author, in the case of optional code reviews):

Please make sure these conditions are met before approving the PR, or request changes if the PR needs improvement:

• The PR is small and has a clear, single focus, or a valid explanation is provided in the description. If needed, please request to split it into smaller PRs.
• Ensure Adequate Unit Test Coverage: The changes are reasonably covered by unit tests or an explanation is provided in the PR description.
• Manual Testing: The author listed all the tests they ran, including smoke tests when needed (e.g., for refactorings). The reviewer confirmed that the PR works as expected on all devices (phone/tablet) and no regressions are added.

[Copilot]

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

[staskus]

I was going back and forth on whether enableCoupons should return a result, or throw an error. In the end, opted for the most straightforward solution - return a boolean. Since the error is handled within the controller, there's no point in propagating the error for the controller's caller.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	29311
	Version	PR #15505
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	55df609
	Installation URL	6isj52tdp64q8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[joshheald]

Looks good. One small question shared inline.

[joshheald]

Why not do this inside the couponsController's enableCoupons function as well? That would make it safe to call it directly on the now-exposed coupons controller. I don't know if that's a good thing or not, so just a question.

[staskus]

I went back and forth on this. It felt like enableCoupons would be a bit misleading since it would do more than just enable but maybe I was overthinking.

On another note, I think this whole method can be removed and we can call couponsController directly from the ItemListView. I'll update.