-
Notifications
You must be signed in to change notification settings - Fork 56
New SEPA Direct Debit integration (3698) #2855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
* | ||
* @var Orders | ||
*/ | ||
private $orders_endpoint; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to always add typehints since we are already on PHP 7.4 +
private $orders_endpoint; | |
private Orders $orders_endpoint; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with this suggestion; when possible, we should use the type hints.
Just want to point out that this is only possible for custom properties, and we cannot add a type hint for properties that are defined without a type in the base class
|
||
use ProcessPaymentTrait; | ||
|
||
const ID = 'ppcp-sepa'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const ID = 'ppcp-sepa'; | |
public const ID = 'ppcp-sepa'; |
* | ||
* @var string | ||
*/ | ||
private $module_url; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, missing typehints for the class
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. 🔗 Test this pull request with WordPress Playground What's included:
Login credentials:
Plugin Details:
🤖 Auto-generated for commit 7a6b72c • Last updated: 2025-09-01T12:28:09.981Z |
Implement SEPA direct debit.
SEPA direct debit features
SEPA Direct Debit allows you to access funds immediately if you opt for Instant Settlements. Delayed settlement option will make funds available in the standard SEPA settlement timeframe of 2-3 days.