[obsolete, but using as a reference] progress on rewriting game store #1503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domino14
force-pushed
the
partitioned-games
branch
from
468d139 to
665604c
Compare
domino14
force-pushed
the
partitioned-games
branch
2 times, most recently
from
7d68c46 to
006d6d0
Compare
- Updated SQL queries in puzzles.sql.go to use past_games table instead of games, adjusting conditions and parameters accordingly. - Changed return types in GetPotentialPuzzleGames and GetPotentialPuzzleGamesAvoidBots functions from pgtype.Text to string for better compatibility. - Modified DBStore methods to handle new parameters and return types, ensuring backward compatibility with pgtype.Text. - Renamed migration tool file from migrate_historical_games.go to main.go for clarity. - Introduced utility functions for parsing and marshaling GameRequest in the migration tool to support both proto and protojson formats. - Enhanced game migration logic to extract and store player rating data and original request ID from quickdata. - Cleaned up sqlc.yaml by removing unnecessary GameRequest type mappings.
domino14
force-pushed
the
partitioned-games
branch
from
7ca702a to
1a1bd16
Compare
|
this PR became too big. In accordance with good principles / Mikado method / and so forth, we're going to split this up into small, independent, working deployable units of work. |
domino14
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should be part 1 of a many-part games table refactor.
The most pressing problem with our games table right now is the inefficiency of the table. We want to start fixing stuff by partitioning games into monthly tables. This will make queries better/faster. It'll also let us make more incremental/smaller/faster backups.
We can later offload partitions to S3 or similar.
Things that must be tested prior to deploy: