-
Notifications
You must be signed in to change notification settings - Fork 1k
[BE 이연호] 1주차 과제 제출합니다. #1111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Timothy-Y-H-Lee
wants to merge
14
commits into
woowacourse-precourse:main
Choose a base branch
from
Timothy-Y-H-Lee:Timothy-Y-H-Lee
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[BE 이연호] 1주차 과제 제출합니다. #1111
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a89c03b
docs: draft functional requirements and feature list after problem an…
9265e19
feat(#1): MVC & TDD - 모델에 사용자의 입력값을 저장
7f2a83c
docs(#2): update feature list
61ccb3c
feat(#2): Service를 이용해서 모델에 사용자의 입력값을 저장
ca9d2a3
feat(#2): Service를 이용해서 모델에 사용자의 입력값을 저장
29305db
docs(#2): 기능목록 업데이트
c22f736
refactor(#2): CalculatorService의 패키지 위치 변경
9058fef
feat(#2): MVC 구조 완성
76acd14
docs(#2): 기능 목록 업데이트: 입력값이 양수만 입력이 가능하도록 테스트 케이스 처리
b06d9df
feat(#2): 입력값이 양수만 입력이 가능하도록 테스트 케이스 처리
28244ef
docs(#2): 기능목록 업데이트 - 사용자의 입력값에서 기본 구분자와 커스텀 구분자를 함께 사용이 가능하도록 테스트 케이…
2d19816
feat(#2): 사용자의 입력값에서 기본 구분자와 커스텀 구분자를 함께 사용이 가능하도록 테스트 케이스 처리
ad712de
docs(#2): 기능목록 업데이트: 실질적으로 Model을 사용해서 구분자로 정리된 숫자 목록을 저장 후, 꺼내어 사용
fa4117b
feat(#2): 실질적으로 Model을 사용해서 구분자로 정리된 숫자 목록을 저장 후, 꺼내어 사용
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
startDelimiter와 endDelimiter는 매직 스트링으로 보이는데, 상수로 분리해두면 의미가 명확해지고 재사용성이 높아질 것 같습니다.
예:
private static final String START_DELIMITER = "//";삼항 연산자를 활용한 부분은 간결하지만, 조건이 길어지면서 가독성이 조금 떨어질 수 있습니다.
조건식을 별도의 변수에 담거나 메서드로 분리하면 읽기가 더 편해질 것 같습니다.