Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] 검색 결과에 대한 정보 제공을 위한 meta tag 추가 #828

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

suyoungj
Copy link
Collaborator

[FE] 검색 결과에 대한 정보 제공을 위한 meta tag 추가

이슈번호

close #827

PR 내용

  • 검색 결과에 대한 정보 제공을 위한 meta tag 추가

<meta name="og:url" content="https://teamby.team" />
<meta name="og:site_name" content="팀바팀" />
<meta name="og:title" content="팀바팀" />
<meta name="og:description" content="쉽고 간단한 팀플 플랫폼, 팀바팀" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

og:image도 설정하는게 좋지 않을까?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

뭐 이런 이미지라도 쓰쉴?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋은데요?

Copy link
Collaborator

@wzrabbit wzrabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@suyoungj suyoungj requested a review from hafnium1923 October 25, 2023 05:46
@hafnium1923
Copy link
Collaborator

근데 이미지 업로드 안했는데 적용되는거야?

@suyoungj
Copy link
Collaborator Author

s3에 올려놨는데 html이 아직 안바껴서 프로덕션 배포해봐야 알듯?

@hafnium1923
Copy link
Collaborator

ㅇㅎ 거기에 올라간거구만 좋아요

Copy link
Collaborator

@hafnium1923 hafnium1923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

열일하시는군뇨
수고하셨슴다

@suyoungj suyoungj requested a review from hafnium1923 October 26, 2023 05:00
@hafnium1923 hafnium1923 merged commit bf98b76 into develop Oct 26, 2023
@hafnium1923 hafnium1923 deleted the feat/fe/meta-tag-추가 branch October 26, 2023 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FE] 검색 시 정보 제공을 위한 meta tag를 추가한다.
3 participants