-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] refactor : 회원 전용 페이지 path 수정 #1070
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
유틸 함수 덕분에 나중에 더 편할 것 같아요~!
@@ -0,0 +1,5 @@ | |||
export const makeRoutePath = (pageName: string, isForMember: boolean = false) => { | |||
let basic = 'user'; | |||
if (isForMember) basic += '/logged-in'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isMemberOnly같은 네이밍도 제안해봅니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
관리해야 할 라우트 경로들이 많아졌는데, 쉽게 유지 보수할 수 있을 것 같아요👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path를 쉽게 관리할 수 있을 것 같네요!!
고생했어용 바다:)
🚀 어떤 기능을 구현했나요 ?
makeRoutePath
유틸함수를 만들어서 보다 편리하게 path를 추가/변경할 수 있도록 했습니다.📚 참고 자료, 할 말