Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] fix: URL 생성 모달에서 체크박스가 선택되지 않은 경우 닫기 버튼을 disabled로 수정 #329

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

chysis
Copy link
Contributor

@chysis chysis commented Aug 12, 2024


🚀 어떤 기능을 구현했나요 ?

  • URL 생성 모달에서 체크박스가 선택되지 않은 경우 닫기 버튼을 disabled로 수정했습니다.

🔥 어떻게 해결했나요 ?

  • 공통 Button 컴포넌트의 type을 조건부로 지정했습니다.

📝 어떤 부분에 집중해서 리뷰해야 할까요?

📚 참고 자료, 할 말

image
image

Copy link
Contributor

@ImxYJL ImxYJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구뜨구뜨

Copy link
Contributor

@BadaHertz52 BadaHertz52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어!!!

Copy link
Contributor

@soosoo22 soosoo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했어요!!

@chysis chysis merged commit 7026082 into develop Aug 13, 2024
5 checks passed
@donghoony donghoony deleted the fe/fix/322-url-modal-button branch August 20, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
4 participants