Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] refactor: 리뷰 상세 페이지 QuestionData 인터페이스에서 hasGuideline, guideline 속성 제거 #340

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

soosoo22
Copy link
Contributor

@soosoo22 soosoo22 commented Aug 13, 2024


🚀 어떤 기능을 구현했나요 ?

  • 리뷰 상세 페이지 QuestionData 인터페이스에서 hasGuideline, guideline 속성을 제거했습니다.

🔥 어떻게 해결했나요 ?

  • 리뷰 상세 페이지 기존 api에 hasGuideline, guideline 속성을 내려줬는데 불필요하다고 판단했습니다. 그래서 QuestionData 인터페이스, 목 데이터에서 관련 속성을 모두 제거했습니다.
export interface QuestionData {
  questionId: number;
  required: boolean;
  questionType: QuestionType;
  content: string;
  optionGroup: OptionGroup | null;
  answer?: string;
}

📝 어떤 부분에 집중해서 리뷰해야 할까요?

  • 변경된 부분이 크지 않아서 집중해서 리뷰할 필요가 있을까요~~

📚 참고 자료, 할 말

  • 화이팅!

Copy link
Contributor

@ImxYJL ImxYJL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

구뜨구뜨

Copy link
Contributor

@BadaHertz52 BadaHertz52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어!!!!

Copy link
Contributor

@chysis chysis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어요!

@chysis chysis merged commit 4098dd7 into develop Aug 13, 2024
5 checks passed
@donghoony donghoony deleted the fe/refactor/337-detailed-review-page-delete-guideline branch August 20, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
4 participants