[FE] refactor: LandingPage에서 사용하는 Input 유효성 검사 함수 분리 및 테스트 작성 #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImxYJL
commented
Aug 14, 2024
| return input.length <= length; | ||
| }; | ||
|
|
||
| const MAX_VALID_REVIEW_GROUP_DATA_INPUT = 50; |
There was a problem hiding this comment.
이 상수 부분은 폼 로직과 관련된 값입니다. 이 상수를 컴포넌트 파일에 둘지 여기다 둘지 고민했는데 이 유틸 함수를 해당 컴포넌트에서만 사용한다고 가정했기 때문에,(추후 기본 함수들은 전역으로 뺄 수도 있겠지만) 해당 컴포넌트의 유효성 검증을 위한 파일로 만들자고 생각해서 일단 여기에 두기로 했습니다
ImxYJL
changed the title
chysis
approved these changes
Aug 14, 2024
Comment on lines
+1
to
+3
| export const isNotEmptyInput = (input: string) => { | ||
| return input !== ''; | ||
| }; |
There was a problem hiding this comment.
사소하지만 부정 조건문으로 판단한 이유가 있을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 어떤 기능을 구현했나요 ?
🔥 어떻게 해결했나요 ?
📝 어떤 부분에 집중해서 리뷰해야 할까요?
📚 참고 자료, 할 말