Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FE] fix: Checkbox의 onChange 이벤트 핸들러가 전달되지 않는 버그 수정 #367

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

ImxYJL
Copy link
Contributor

@ImxYJL ImxYJL commented Aug 15, 2024


🚀 어떤 기능을 구현했나요 ?

  • 핸들러 이름을 onChange에서 handleChange로 변경하면서 rest props를 통해 핸들러가 전달되지 않던 문제를 해결했습니다.

🔥 어떻게 해결했나요 ?

  • input에 명시적으로 handleChange를 전달했습니다.

📝 어떤 부분에 집중해서 리뷰해야 할까요?

📚 참고 자료, 할 말

  • rest에 대한 이해가 부족했습니다. 핸들러를 rest로 전달하고 있으니까 핸들러 이름이 변경되어도 괜찮을 거라고 생각했는데 기본 속성이 아니라 명시적으로 전달해줘야 했습니다.
  • 혼란을 드려서 죄송합니다 ㅠㅠㅠㅠㅠ

Copy link
Contributor

@chysis chysis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onChangehandleChange가 모두 전달될 수 있었는데, 이제는 handleChange만 사용하면 될 것 같네요.
버그 수정 고마워요!👍

Copy link
Contributor

@soosoo22 soosoo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠르게 수정해주셨네요! 올리 수고했어요!

Copy link
Contributor

@soosoo22 soosoo22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve 할게요~

Copy link
Contributor

@BadaHertz52 BadaHertz52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏👏👏👏

@BadaHertz52 BadaHertz52 merged commit 18f9a90 into develop Aug 15, 2024
4 checks passed
@donghoony donghoony deleted the fe/fix/366-checkbox-onchange-handler branch August 20, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FE] Checkbox에서 handler가 작동하지 않는 버그를 수정한다.
4 participants