[๐ ๋ฐฉํ์ถ ์์ฝ ์ธ๋ถ API ์ฐ๋ 3๋จ๊ณ] ํฐ๋ด ๋ฏธ์ ์ ์ถํฉ๋๋ค.#699
Open
JohnPrk wants to merge 5 commits into
Open
[๐ ๋ฐฉํ์ถ ์์ฝ ์ธ๋ถ API ์ฐ๋ 3๋จ๊ณ] ํฐ๋ด ๋ฏธ์
์ ์ถํฉ๋๋ค.#699JohnPrk wants to merge 5 commits into
JohnPrk wants to merge 5 commits into
Conversation
- capacity์ refillPerSec๋ฅผ ๊ฐ์ง ํ ํฐ ๋ฒํท์ ์ธ๋ถ ์์กด์ฑ ์์ด ์ถ๊ฐ - ๋ณด์ถฉ๋์ ๋ง์ง๋ง ๋ณด์ถฉ ์ดํ ๊ฒฝ๊ณผ ์๊ฐ ร refillPerSec๋ก ๊ณ์ฐํ๊ณ capacity๋ฅผ ์ํ์ผ๋ก ์ ์ง - tryConsume์ผ๋ก ํ ํฐ์ 1๊ฐ์ฉ ์๋นํ๊ณ retryAfterSeconds๋ก 1๊ฐ๊ฐ ์ฐฐ ๋๊น์ง ํ์ํ ์ด๋ฅผ ์ฌ๋ฆผ์ผ๋ก ๋ฐํ - ์๊ฐ ์์กด์ LongSupplier๋ก ์ฃผ์ ํด ๊ฐ์ง ์๊ณ๋ก ๊ฒฐ์ ์ ํ ์คํธํ๊ณ synchronized๋ก ๋์์ฑ ๋ณด์ฅ
- HandlerInterceptor๋ก preHandle์์ tryConsume์ด ์คํจํ๋ฉด ์ปจํธ๋กค๋ฌ๋ฅผ ํธ์ถํ์ง ์๊ณ 429์ Retry-After ํค๋๋ก ์๋ต - /reservations์ /payments ๊ฒฝ๋ก์ ์ธํฐ์ ํฐ๋ฅผ ๋ฑ๋กํ๊ณ ์ธ๋ฐ์ด๋ ํ ํฐ ๋ฒํท์ ๋น์ผ๋ก ๋ถ๋ฆฌ - capacityยทrefillPerSec๋ฅผ rate-limit.*๋ก ์ธ๋ถํํด ์ฝ๋ ์์ ์์ด ๊ฑฐ๋ถ ์์ ์ ์กฐ์
- ํ ์ค ํธ์ถ RestClient์ ClientHttpRequestInterceptor๋ฅผ ๋ฑ๋กํด 429๋ฉด Retry-After ์ด๋งํผ ๋๊ธฐ ํ ์ฌ์๋ - Retry-After๊ฐ ์์ผ๋ฉด ๊ธฐ๋ณธ ๊ฐ๊ฒฉ์ผ๋ก ํด๋ฐฑํ๊ณ maxAttempts๋ฅผ ๋์ผ๋ฉด ๋๋ฉ์ธ ์์ธ๋ก ์คํจํด ๋ฌดํ ์ฌ์๋๋ฅผ ์ฐจ๋จ - ๋๊ธฐ ๋์์ Sleeper๋ก ์ฃผ์ ํด ํ ์คํธ์์ ์ค์ ๋๊ธฐ ์์ด ์ฌ์๋ ํ์์ ๊ฐ๊ฒฉ์ ๊ฒ์ฆ - maxAttemptsยท๊ธฐ๋ณธ ๊ฐ๊ฒฉ์ toss.retry.*๋ก ์ธ๋ถํ
- ๊ฒ์ดํธ์จ์ด RestClient์ ์ธํฐ์ ํฐ๋ฅผ ํ๋ ๋ ๋ฑ๋กํด ํธ์ถ ์ tryConsume์ผ๋ก ํ ํฐ์ ์๋นํ๊ณ ์์ผ๋ฉด ์ธ๋ถ๋ก ๋ณด๋ด์ง ์๊ณ OutboundRateLimitException์ผ๋ก ๊ฑฐ๋ถ - ๋ค์ด์ค๋ ์ชฝ๊ณผ ๊ฐ์ TokenBucketRateLimiter๋ฅผ ๋ฐฉํฅ๋ง ๋ฐ๊ฟ ์ฌ์ฌ์ฉํ๊ณ ๋๊ฐ๋ ํ๋๋ฅผ outbound-rate-limit.*๋ก ๋ถ๋ฆฌ ์ธ๋ถํ - ๊ฑฐ๋ถ ์ 503๊ณผ Retry-After ํค๋๋ก ์๋ตํ๋๋ก ์์ธ ํธ๋ค๋ฌ์ ProblemType์ ์ถ๊ฐ
- ๋ค์ ๋์ ์์ฒญ์ ๊ฐ๋ณ๊ฒ ์์ฑํ๋๋ก ๊ณ ์ ์ค๋ ๋ ํ์ ๊ฐ์ ์ค๋ ๋ ํ๋ก ๊ต์ฒด
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
์ฒดํฌ ๋ฆฌ์คํธ
test๋ฅผ ์คํํ์ ๋, ๋ชจ๋ ํ ์คํธ๊ฐ ์ ์์ ์ผ๋ก ํต๊ณผํ๋์?๋ฒ ์ด์ค ์ฝ๋ ์ ํ ์ฒดํฌ
์ด๋ค ๋ถ๋ถ์ ์ง์คํ์ฌ ๋ฆฌ๋ทฐํด์ผ ํ ๊น์?