Simplify iOS Settings #179
Open
+14
−224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
force-pushed
the
align/settings
branch
from
0f3cea3 to
7e25296
Compare
The host app doesn’t need to parse it, so we can pass the raw settings
jkmassel
force-pushed
the
align/settings
branch
from
7e25296 to
f3e64e4
Compare
|
I plan to review and test this once we have a sibling WP-iOS PR integrating the latest configuration builder. That will allow testing real-world editor settings in WP-iOS. |
dcalhoun
reviewed
Sep 12, 2025
There was a problem hiding this comment.
This likely close to being ready to merge, but I encountered issues while testing the sibling WP-iOS PR: wordpress-mobile/WordPress-iOS#24662 (review)
There was a problem hiding this comment.
I feel we should address the incomplete cookie configuration referenced in #146 (comment). Would you be willing to address that in this PR or a follow-up PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Simplifies the configuration for passing settings fetched from the API.
Why?
We currently parse the settings then convert them back to raw JSON. This is wasteful for performance reasons, but it also makes the types confusing.
How?
Allows raw JSON to be passed to GutenbergKit for settings.
Testing Instructions
The test suite has been updated to reflect these changes.
Accessibility Testing Instructions
n/a
Screenshots or screencast
n/a