Adopt PluginDirectoryServiceRemote changes
#22622
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22622-1d50eb3 | |
| Version | 24.2 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 1d50eb3 | |
| App Center Build | WPiOS - One-Offs #8851 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22622-1d50eb3 | |
| Version | 24.2 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 1d50eb3 | |
| App Center Build | jetpack-installable-builds #7881 |
mokagio
changed the title
PluginDirectoryServiceRemote changesPluginDirectoryServiceRemote changes
mokagio
approved these changes
Feb 16, 2024
crazytonyli
changed the base branch from
trunk
to
wordpresskit-error-refactor
crazytonyli
force-pushed
the
refactor-plugin-directory-service
branch
from
5530abb to
a3b481c
Compare
crazytonyli
force-pushed
the
refactor-plugin-directory-service
branch
from
7012d3d to
39af558
Compare
crazytonyli
force-pushed
the
refactor-plugin-directory-service
branch
from
39af558 to
6df354c
Compare
See how the UI tests failed in https://buildkite.com/automattic/wordpress-ios/builds/20452#018dbe88-2fc5-4998-ad35-1b455f547b59 The WordPressKit PR is wordpress-mobile/WordPressKit-iOS#727
mokagio
referenced
this pull request
Feb 19, 2024
See how the UI tests failed in https://buildkite.com/automattic/wordpress-ios/builds/20452#018dbe88-2fc5-4998-ad35-1b455f547b59 The WordPressKit PR is wordpress-mobile/WordPressKit-iOS#727
Open
2 tasks
mokagio
reviewed
Feb 19, 2024
| @@ -51,7 +51,7 @@ end | |||
|
|
|||
| def wordpress_kit | |||
| # pod 'WordPressKit', '~> 13.0' | |||
| pod 'WordPressKit', git: 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', commit: 'dfb2134ca3b91233d44b3551d91844bf2087996f' | |||
| pod 'WordPressKit', git: 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', commit: '3df47e113c7647b76c049180e39489e3af7a27dc' | |||
There was a problem hiding this comment.
This commit points to wordpress-mobile/WordPressKit-iOS#727 which, I'm happy to say, seems to address the reader issue that the UI tests picked up in previous runs (see #22612)
|
Changes in this PR have been moved to #22612 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR is built on top of #22612.
This PR updates the app code to accept the
PluginDirectoryServiceRemotebreaking changes introduced in wordpress-mobile/WordPressKit-iOS#725.Test Instructions
Regression Notes
Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
What's described in the "Test Instructions"
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: N/A