-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Build and test Keystone and WordPressData in CI #24391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That's even though there is not yet a test target for Keystone.
cd8e257
to
57df3e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces new CI steps for running unit tests on the Keystone and WordPressData frameworks, providing immediate feedback on compilation and test results.
- Adds a CI step for Keystone unit tests
- Adds a CI step for WordPressData unit tests
Files not reviewed (1)
- WordPress/WordPress.xcodeproj/xcshareddata/xcschemes/Keystone.xcscheme: Language not supported
Comments suppressed due to low confidence (2)
.buildkite/pipeline.yml:87
- [nitpick] Consider renaming the context to 'Keystone Unit Tests' to maintain consistency with the step label.
context: "Unit Tests Keystone"
.buildkite/pipeline.yml:101
- [nitpick] Consider renaming the context to 'WordPressData Unit Tests' to align with the step label and improve consistency.
context: "Unit Tests WordPressData"
|
App Name | WordPress | |
Configuration | Release-Alpha | |
Build Number | 27043 | |
Version | PR #24391 | |
Bundle ID | org.wordpress.alpha | |
Commit | 0ae6031 | |
Installation URL | 2grqniquvcqm8 |
|
App Name | Jetpack | |
Configuration | Release-Alpha | |
Build Number | 27043 | |
Version | PR #24391 | |
Bundle ID | com.jetpack.alpha | |
Commit | 0ae6031 | |
Installation URL | 5i16io6fvcck8 |
-scheme Keystone \ | ||
-destination 'platform=iOS Simulator,OS=18.2,name=iPhone 16' \ | ||
test \ | ||
| xcbeautify |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to fastlane to be consistent with how other tests execute?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good observation. To do this, we'd need a custom lane. Alternatively, we could do bundle exec fastlane run scan...
but at that point, that's not that different from calling xcodebuild
.
I didn't document that, but I see these steps as temporary only, just to get fast CI feedback for these foundational modules that are still in flux. That is, we should get to the point when they are properly integrated and they run as part of the apps test suites, or to the point where the apps are but thin shelters and then we'd think about how to test all modules and frameworks in isolation and fast in CI.
While neither framework is good to go, I find it useful to have CI feedback on their compilation and unit tests status.
Granted, Keystone has no tests at the moment, but at least we have the step in place.
As for WordPressData, there are only two dummy tests, but, again, at least it's in place. #24378 and its follow ups will changes this.