Skip to content

Build and test Keystone and WordPressData in CI #24391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 2, 2025

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Apr 2, 2025

While neither framework is good to go, I find it useful to have CI feedback on their compilation and unit tests status.

Granted, Keystone has no tests at the moment, but at least we have the step in place.

image

As for WordPressData, there are only two dummy tests, but, again, at least it's in place. #24378 and its follow ups will changes this.

image

@mokagio mokagio added this to the 25.9 milestone Apr 2, 2025
@mokagio mokagio added the Tooling Build, Release, and Validation Tools label Apr 2, 2025
@mokagio mokagio self-assigned this Apr 2, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Apr 2, 2025

1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

That's even though there is not yet a test target for Keystone.
@mokagio mokagio force-pushed the mokagio/build-keystone-and-data-in-ci branch from cd8e257 to 57df3e5 Compare April 2, 2025 00:40
@mokagio mokagio requested review from crazytonyli, kean, a team and Copilot April 2, 2025 00:54
@mokagio mokagio marked this pull request as ready for review April 2, 2025 00:54
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces new CI steps for running unit tests on the Keystone and WordPressData frameworks, providing immediate feedback on compilation and test results.

  • Adds a CI step for Keystone unit tests
  • Adds a CI step for WordPressData unit tests
Files not reviewed (1)
  • WordPress/WordPress.xcodeproj/xcshareddata/xcschemes/Keystone.xcscheme: Language not supported
Comments suppressed due to low confidence (2)

.buildkite/pipeline.yml:87

  • [nitpick] Consider renaming the context to 'Keystone Unit Tests' to maintain consistency with the step label.
context: "Unit Tests Keystone"

.buildkite/pipeline.yml:101

  • [nitpick] Consider renaming the context to 'WordPressData Unit Tests' to align with the step label and improve consistency.
context: "Unit Tests WordPressData"

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27043
VersionPR #24391
Bundle IDorg.wordpress.alpha
Commit0ae6031
Installation URL2grqniquvcqm8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27043
VersionPR #24391
Bundle IDcom.jetpack.alpha
Commit0ae6031
Installation URL5i16io6fvcck8
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

-scheme Keystone \
-destination 'platform=iOS Simulator,OS=18.2,name=iPhone 16' \
test \
| xcbeautify
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to fastlane to be consistent with how other tests execute?

Copy link
Contributor Author

@mokagio mokagio Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good observation. To do this, we'd need a custom lane. Alternatively, we could do bundle exec fastlane run scan... but at that point, that's not that different from calling xcodebuild.

I didn't document that, but I see these steps as temporary only, just to get fast CI feedback for these foundational modules that are still in flux. That is, we should get to the point when they are properly integrated and they run as part of the apps test suites, or to the point where the apps are but thin shelters and then we'd think about how to test all modules and frameworks in isolation and fast in CI.

@mokagio mokagio added this pull request to the merge queue Apr 2, 2025
Merged via the queue into trunk with commit 096134c Apr 2, 2025
31 checks passed
@mokagio mokagio deleted the mokagio/build-keystone-and-data-in-ci branch April 2, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tooling Build, Release, and Validation Tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants