Skip to content

Remove WordPressDataObjC and WordPressData modules #24402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions Modules/Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ let package = Package(
.library(name: "NotificationServiceExtensionCore", targets: ["NotificationServiceExtensionCore"]),
.library(name: "ShareExtensionCore", targets: ["ShareExtensionCore"]),
.library(name: "SFHFKeychainUtils", targets: ["SFHFKeychainUtils"]),
// Note: WordPressData the Swift package is currently unused.
// We are leaving it here to be ready for the future when we'll be able to write the current WordPressData framework as a Swift package.
.library(name: "WordPressData", targets: ["WordPressData"]),
.library(name: "WordPressFlux", targets: ["WordPressFlux"]),
.library(name: "WordPressShared", targets: ["WordPressShared"]),
.library(name: "WordPressUI", targets: ["WordPressUI"]),
Expand Down Expand Up @@ -123,14 +120,6 @@ let package = Package(
.product(name: "ScreenObject", package: "ScreenObject"),
.product(name: "XCUITestHelpers", package: "ScreenObject"),
], swiftSettings: [.swiftLanguageMode(.v5)]),
.target(name: "WordPressDataObjC"),
.target(
name: "WordPressData",
dependencies: [
.target(name: "WordPressDataObjC"),
.target(name: "WordPressSharedObjC")
]
),
.target(name: "WordPressFlux", swiftSettings: [.swiftLanguageMode(.v5)]),
.target(name: "WordPressCore", dependencies: [.target(name: "WordPressShared"), .product(name: "WordPressAPI", package: "wordpress-rs")]),
.target(name: "WordPressSharedObjC", resources: [.process("Resources")], swiftSettings: [.swiftLanguageMode(.v5)]),
Expand Down Expand Up @@ -255,7 +244,6 @@ enum XcodeSupport {
"SFHFKeychainUtils",
"ShareExtensionCore",
"WordPressFlux",
"WordPressDataObjC", // Currently empty, here for future proofing
"WordPressShared",
"WordPressReader",
"WordPressUI",
Expand Down Expand Up @@ -292,7 +280,6 @@ enum XcodeSupport {
]),
.xcodeTarget("XcodeTarget_WordPressTests", dependencies: testDependencies + [
"SFHFKeychainUtils",
"WordPressDataObjC", // Currently empty, here for future proofing
"WordPressShared",
"WordPressUI",
.product(name: "Gravatar", package: "Gravatar-SDK-iOS"),
Expand Down
1 change: 0 additions & 1 deletion Modules/Sources/WordPressData/WordPressData.swift

This file was deleted.

3 changes: 0 additions & 3 deletions Modules/Sources/WordPressDataObjC/Empty.m

This file was deleted.

3 changes: 0 additions & 3 deletions Modules/Sources/WordPressDataObjC/include/Empty.h

This file was deleted.

1 change: 0 additions & 1 deletion WordPress/Classes/Categories/Media+Extensions.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#import "Media+Extensions.h"
#import "MediaService.h"
#import "Blog.h"
@import WordPressDataObjC;
@import WordPressShared;
#ifdef KEYSTONE
#import "Keystone-Swift.h"
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Models/AbstractPost.m
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#import "AbstractPost.h"
#import "Media.h"
@import WordPressDataObjC;
#ifdef KEYSTONE
#import "Keystone-Swift.h"
#else
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Models/BasePost.m
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#import "BasePost.h"
#import "Media.h"
@import WordPressDataObjC;

@import WordPressShared;

Expand Down
9 changes: 4 additions & 5 deletions WordPress/Classes/Models/Blog/Blog.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#import "Blog.h"
#import "WPAccount.h"
#import "AccountService.h"
@import WordPressDataObjC;
@import WordPressShared;
#ifdef KEYSTONE
#import "Keystone-Swift.h"
Expand Down Expand Up @@ -155,7 +154,7 @@ - (void)didTurnIntoFault

- (NSNumber *)organizationID {
NSNumber *organizationID = [self primitiveValueForKey:@"organizationID"];

if (organizationID == nil) {
return @0;
} else {
Expand Down Expand Up @@ -188,7 +187,7 @@ - (NSString *)displayURL
DDLogInfo(@"Blog display URL is nil");
return nil;
}

NSError *error = nil;
NSRegularExpression *protocol = [NSRegularExpression regularExpressionWithPattern:@"http(s?)://" options:NSRegularExpressionCaseInsensitive error:&error];
NSString *result = [NSString stringWithFormat:@"%@", [protocol stringByReplacingMatchesInString:self.url options:0 range:NSMakeRange(0, [self.url length]) withTemplate:@""]];
Expand Down Expand Up @@ -306,7 +305,7 @@ - (NSArray *)sortedPostFormats
}

- (NSArray *)sortedPostFormatNames
{
{
return [[self sortedPostFormats] wp_map:^id(NSString *key) {
return self.postFormats[key];
}];
Expand Down Expand Up @@ -794,7 +793,7 @@ - (NSSet *)allowedFileTypes
if (!allowedFileTypes || allowedFileTypes.count == 0) {
return nil;
}

return [NSSet setWithArray:allowedFileTypes];
}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import CoreData
import WordPressDataObjC

public protocol CoreDataStackSwift: CoreDataStack {

Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Models/Media.m
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#import "Media.h"
@import WordPressDataObjC;
#ifdef KEYSTONE
#import "Keystone-Swift.h"
#else
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Models/ReaderPost.m
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#import "ReaderPost.h"
@import WordPressDataObjC;
#import "SourcePostAttribution.h"
#import "WPAccount.h"
#ifdef KEYSTONE
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Models/Theme.m
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
#import "Theme.h"
#import "Blog.h"
@import WordPressDataObjC;
#import "WPAccount.h"
#import "AccountService.h"
#ifdef KEYSTONE
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Services/AccountService.m
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
#import "Blog.h"
#import "BlogService.h"

@import WordPressDataObjC;
@import WordPressKit;
@import WordPressShared;

Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Services/BlogService.m
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#import "Blog.h"
#import "WPAccount.h"
#import "AccountService.h"
@import WordPressDataObjC;
#import "WPError.h"
#import "Media.h"
#import "PostCategoryService.h"
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Services/CommentService.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#import "CommentService.h"
#import "AccountService.h"
#import "Blog.h"
@import WordPressDataObjC;
#import "ReaderPost.h"
#import "WPAccount.h"
#import "PostService.h"
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Services/Facades/BlogSyncFacade.m
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#import "BlogSyncFacade.h"
@import WordPressDataObjC;
#import "BlogService.h"
#import "AccountService.h"
#import "Blog.h"
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Services/MediaService.m
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
#import "AccountService.h"
#import "Media.h"
#import "WPAccount.h"
@import WordPressDataObjC;
@import WordPressShared;
#import "Blog.h"
#import <MobileCoreServices/MobileCoreServices.h>
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Services/MenusService.m
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
#import "Menu.h"
#import "MenuItem.h"
#import "MenuLocation.h"
@import WordPressDataObjC;
#import "PostService.h"
#ifdef KEYSTONE
#import "Keystone-Swift.h"
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Services/PostCategoryService.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#import "PostCategoryService.h"
#import "PostCategory.h"
#import "Blog.h"
@import WordPressDataObjC;
#ifdef KEYSTONE
#import "Keystone-Swift.h"
#else
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Services/PostService.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#import "PostService.h"
#import "PostCategory.h"
#import "PostCategoryService.h"
@import WordPressDataObjC;
#import "CommentService.h"
#import "MediaService.h"
#import "Media.h"
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Services/PostTagService.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#import "PostTagService.h"
#import "Blog.h"
#import "PostTag.h"
@import WordPressDataObjC;
#ifdef KEYSTONE
#import "Keystone-Swift.h"
#else
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Services/Reader Post/ReaderPostService.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#import "ReaderPostService.h"

#import "AccountService.h"
@import WordPressDataObjC;
#import "ReaderGapMarker.h"
#import "ReaderPost.h"
#import "ReaderSiteService.h"
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Services/ReaderSiteService.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#import "ReaderSiteService.h"

#import "AccountService.h"
@import WordPressDataObjC;
#import "ReaderPostService.h"
#import "ReaderPost.h"
#import "WPAccount.h"
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Services/ReaderTopicService.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#import "ReaderTopicService.h"

#import "AccountService.h"
@import WordPressDataObjC;
#import "ReaderPost.h"
#import "ReaderPostService.h"
#import "WPAccount.h"
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Services/ThemeService.m
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
#import "Blog.h"
#import "Theme.h"
#import "WPAccount.h"
@import WordPressDataObjC;
#ifdef KEYSTONE
#import "Keystone-Swift.h"
#else
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#import "WPAnalyticsTrackerAutomatticTracks.h"
@import WordPressDataObjC;
#import "AccountService.h"
#import "BlogService.h"
#import "WPAccount.h"
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/Utility/Analytics/WPAppAnalytics.m
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
@import WordPressDataObjC;
@import NSObject_SafeExpectations;

#import "WPAppAnalytics.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
#import "AccountService.h"
#import "BlogService.h"
#import "CommentsViewController.h"
@import WordPressDataObjC;
#import "SiteSettingsViewController.h"
#import "SharingViewController.h"
#import "StatsViewController.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

#import "Blog.h"
#import "BlogService.h"
@import WordPressDataObjC;
#import "PostCategory.h"
#import "PostCategoryService.h"
#import "SettingsSelectionViewController.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
#import "MenuItemEditingFooterView.h"
#import "MenuItemSourceViewController.h"
#import "MenuItemTypeViewController.h"
@import WordPressDataObjC;
#ifdef KEYSTONE
#import "Keystone-Swift.h"
#else
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#import "MenuItemView.h"
#import "MenuItemInsertionView.h"
#import "MenuItemsVisualOrderingView.h"
@import WordPressDataObjC;
#import "Menu+ViewDesign.h"
#ifdef KEYSTONE
#import "Keystone-Swift.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#import "MenuItemsViewController.h"
#import "MenuItemEditingViewController.h"
#import "Menu+ViewDesign.h"
@import WordPressDataObjC;
#import "WPAppAnalytics.h"
#ifdef KEYSTONE
#import "Keystone-Swift.h"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
#import "Media.h"
#import "SettingsSelectionViewController.h"
#import "SharingDetailViewController.h"
@import WordPressDataObjC;
#import "MediaService.h"
#ifdef KEYSTONE
#import "Keystone-Swift.h"
Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/ViewRelated/Stats/StatsViewController.m
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
#endif
#import "WPAppAnalytics.h"

@import WordPressDataObjC;
@import WordPressShared;
@import Reachability;

Expand Down
1 change: 0 additions & 1 deletion WordPress/Classes/ViewRelated/System/WPTabBarController.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#import "WPTabBarController.h"

#import "AccountService.h"
@import WordPressDataObjC;
#import "BlogService.h"
#import "Blog.h"

Expand Down
1 change: 0 additions & 1 deletion WordPress/WordPressTest/BlogServiceTest.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
#import <XCTest/XCTest.h>
#import "AccountService.h"
#import "BlogService.h"
@import WordPressDataObjC;
#import "Blog.h"
#import "WPAccount.h"
#import "WordPressTest-Swift.h"
Expand Down
1 change: 0 additions & 1 deletion WordPress/WordPressTest/ReaderPostServiceTest.m
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
@import WordPressDataObjC;

#import <XCTest/XCTest.h>

Expand Down