Skip to content

Add remaining public APIs for Keystone #24406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 7, 2025

Conversation

kean
Copy link
Contributor

@kean kean commented Apr 3, 2025

This PR gets Keystone to compile again (when #24399 and #24404 are also merged). It contains a lot of no-brainer changes, but there are some minor Swift rewrites too (also no-brainer).

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the General label Apr 3, 2025
@kean kean added this to the 25.9 milestone Apr 3, 2025
@kean kean requested a review from crazytonyli April 3, 2025 16:43
@dangermattic
Copy link
Collaborator

3 Warnings
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27102
VersionPR #24406
Bundle IDcom.jetpack.alpha
Commit6632d02
Installation URL225h8o39hfgh0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27102
VersionPR #24406
Bundle IDorg.wordpress.alpha
Commit6632d02
Installation URL3343ju8d5f2ag
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@kean kean requested a review from mokagio April 3, 2025 18:30
@mokagio mokagio added this pull request to the merge queue Apr 7, 2025
@mokagio
Copy link
Contributor

mokagio commented Apr 7, 2025

Unlocked merging to address conflicts with #24378, if any

Merged via the queue into trunk with commit 6ec552f Apr 7, 2025
33 checks passed
@mokagio mokagio deleted the task/keystone-precursor-dkn092hfjd90wj branch April 7, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants