Skip to content

Fixing/Implementing quality of life improvements to Issue #24206 #24481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

matthewsun04
Copy link

@matthewsun04 matthewsun04 commented Apr 20, 2025

Modifications following issues raised by #24207.

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@crazytonyli
Copy link
Contributor

Thanks for the changes! It'll be okay to merge this PR once the conflicts are resolved.

@kean
Copy link
Contributor

kean commented Apr 22, 2025

Hey,

Modifications following issues raised by #24207.

Could you please elaborate on what issues it's referring to? The linked PR doesn't seem to contain any related changes.

shortVersionString

This method has some additional logic for DEBUG mode on top of just reading CFBundleShortVersionString. I don't think we should continue to use it, and it can't simply replaced the code that reads CFBundleShortVersionString as it's not fully equivalent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants