Add bare bone test for migration to 154 to 155 #24496
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 27499 | |
| Version | PR #24496 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 2a17e73 | |
| Installation URL | 7kvips8m2c8tg |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 27499 | |
| Version | PR #24496 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 2a17e73 | |
| Installation URL | 7lkjp4q4tb7e8 |
mokagio
force-pushed
the
mokagio/test-154-155-migration
branch
from
3ff73ba to
050734f
Compare
See the silent failure https://buildkite.com/automattic/wordpress-ios/builds/27496 due to the pipe
See how the following build failed https://buildkite.com/automattic/wordpress-ios/builds/27498/steps?sid=01966692-5a11-457c-8c19-e75c0b550aa7 This commit does not add all the necessary imports
First, convert all entities to "Global Namespace" with ``` sed -i '' -E 's/representedClassName="(WordPress)?(\.)?([^"]+)"/representedClassName="\3"/g' \ Sources/WordPressData/Resources/WordPress.xcdatamodeld/WordPress\ *.xcdatamodel/contents ``` Then, set the entities that need the "Current Product Module", using #24494 as the source for which to pick ``` sed -i '' -E 's/representedClassName="(ManagedAccountSettings|BlogAuthor|BloggingPrompt|BloggingPromptSettings|BloggingPromptSettingsReminderDays|BlogSettings|DiffAbstractValue|DiffContentValue|DiffTitleValue|ManagedDomain|ManagedPerson|Plan|PlanFeature|PlanGroup|PublicizeConnection|PublicizeService|ReaderCard|Revision|RevisionDiff|Role)"/representedClassName=".\1"/g' \ Sources/WordPressData/Resources/WordPress.xcdatamodeld/WordPress\ *.xcdatamodel/contents ``` Notice that `Sources/WordPressData/Resources/WordPress.xcdatamodeld/WordPress 155.xcdatamodel/contents` did not change, which is a point in favor of showing this scripted change being correct.
|
crazytonyli
reviewed
Apr 24, 2025
| @@ -814,7 +814,7 @@ | |||
| <attribute name="slug" attributeType="String" syncable="YES"/> | |||
| <relationship name="blog" maxCount="1" deletionRule="Nullify" destinationEntity="Blog" inverseName="roles" inverseEntity="Blog" syncable="YES"/> | |||
| </entity> | |||
| <entity name="SharingButton" representedClassName="WordPress.SharingButton" syncable="YES"> | |||
| <entity name="SharingButton" representedClassName="SharingButton" syncable="YES"> | |||
There was a problem hiding this comment.
There is no . in the SharingButton class name, and a few other entities. Is that expected?
Base automatically changed from
task/wpdata-fdsaf
to
mokagio/wordpressdata-target-xcdatamodeld-workbench-2-move-files
April 24, 2025 13:44
|
Closing after @kean's input here
👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion at #24494 (comment)
Problem: How do we know the migration from model version 154 to 155 works, in particular because the module for the entities changed in 155?
Proposed solution: Add unit tests to exercise the 154 -> 155 migration
We don't even have to merge this, might be enough to just see them green in CI and make a note.