Skip to content

Add Newsletter Subscribers FF and update WPKit #24507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 30, 2025
Merged

Conversation

kean
Copy link
Contributor

@kean kean commented Apr 28, 2025

Code I used to test it (added to MySiteViewController.swift):

        Task {
            let service = PeopleServiceRemote(wordPressComRestApi: self.blog!.wordPressComRestApi!)
            do {
                let subs = try await service.getSubscribers(siteID: Int(self.blog!.dotComID!), page: nil, perPage: nil, parameters: .init())
                print(subs)
            } catch {
                print(error)
            }
        }

@kean kean added the General label Apr 28, 2025
@kean kean added this to the 25.9 milestone Apr 28, 2025
@dangermattic
Copy link
Collaborator

dangermattic commented Apr 28, 2025

1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 28, 2025

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27556
VersionPR #24507
Bundle IDorg.wordpress.alpha
Commit27b0c00
Installation URL1dih6n7hf5i2o
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Apr 28, 2025

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27556
VersionPR #24507
Bundle IDcom.jetpack.alpha
Commit27b0c00
Installation URL7caehf3r3ksv0
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@@ -48,7 +48,7 @@ let package = Package(
.package(url: "https://github.com/wordpress-mobile/MediaEditor-iOS", branch: "task/spm-support"),
.package(url: "https://github.com/wordpress-mobile/NSObject-SafeExpectations", from: "0.0.6"),
.package(url: "https://github.com/wordpress-mobile/NSURL-IDN", branch: "trunk"),
.package(url: "https://github.com/wordpress-mobile/WordPressKit-iOS", branch: "wpios-edition"),
.package(url: "https://github.com/wordpress-mobile/WordPressKit-iOS", branch: "task/new-subscibers-api"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have approvied the WPKit PR. This change can be discarded once the WPKit PR is merged.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated it to point to wpios-edition.

@kean kean force-pushed the task/new-subscribers-screen branch from f454a55 to 374db78 Compare April 30, 2025 14:10
@kean kean enabled auto-merge April 30, 2025 14:55
@kean kean added this pull request to the merge queue Apr 30, 2025
Merged via the queue into trunk with commit 096428c Apr 30, 2025
32 of 34 checks passed
@kean kean deleted the task/new-subscribers-screen branch April 30, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants