-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add a dedicated screen for uploading media #24656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: media-upload-blocking-ui
Are you sure you want to change the base?
Add a dedicated screen for uploading media #24656
Conversation
|
|
App Name | Jetpack | |
Configuration | Release-Alpha | |
Build Number | 28127 | |
Version | PR #24656 | |
Bundle ID | com.jetpack.alpha | |
Commit | 5735124 | |
Installation URL | 7jrshvf96ej5g |
|
App Name | WordPress | |
Configuration | Release-Alpha | |
Build Number | 28127 | |
Version | PR #24656 | |
Bundle ID | org.wordpress.alpha | |
Commit | 5735124 | |
Installation URL | 098pjsei7t8c0 |
Jeremy talked about this in the meetup. The main idea is no background uploads. My understanding is that a blocking UI gives the impression that users have to wait on this screen; there might be a lower chance that they'll switch to other apps. So, the upload will be more reliable.
I didn't know that. I can have a look. |
My recollection is that it was mentioned in the context of "syncing" posts, which we have no API for, and similar topics. Uploading media is a pretty clear scenario where you actually do want background uploads. Ideally, it would be using background
I think it's just as likely they'll be annoyed by it and will background the app to wait until the upload finishes, which is the opposite of what you want and will not help, unless they app can handle background uploads.
Are they currently unreliable? In the worst-case scenario, the app gets terminated during the upload, and it just restarts when you reopen it. Not sure how well it's implemented atm, but it's a pretty basic scenario to cover. |
Note
This PR is built on top of #24655.
Description
This PR adds a new screen, "Uploading Media", which is presented after the user selects photos/documents to upload. This modal is not dismissible until all uploads are completed.
Users can stop and restart the uploads on this screen. However, this may not work correctly at this time until Automattic/wordpress-rs#794 (which resolves an issue with uploading media) is merged.
Simulator.Screen.Recording.-.iPhone.16.-.2025-07-07.at.22.15.13.mp4
Testing instructions