Use TagsView for "Site Settings -> Tags" #24674
Conversation
Generated by 🚫 Danger |
|
| if let total { | ||
| self.total = total + newItems.count | ||
| } | ||
| } |
There was a problem hiding this comment.
How should the Data View handle a new item is added from the client side? Like adding a new tag in this case.
We should not refresh the Data View, because the new item may not be on the first page.
We can insert the new item into the fetched items. But where? We can only try to mimic the server-side implementation, based on the order of response items. Then the DataViewPaginatedResponse needs to have a sorting function, which may complicate things.
In this PR, I went with the simplest solution, where the new item is placed at the top of the list.
Let me know what you think, @kean
There was a problem hiding this comment.
Inserting at the top seems like the best option.
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 28191 | |
| Version | PR #24674 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 218eb05 | |
| Installation URL | 0l4urakocdcr0 |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 28191 | |
| Version | PR #24674 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 218eb05 | |
| Installation URL | 0m320cqit15ig |
Note
This PR is built on top of #24670.
Description
Following the existing design, but implemented with SwiftUI. The existing UI has an issue with loading a large number of tags, which is fixed in the new implementation (see https://linear.app/a8c/issue/CMM-96).
old.mp4
new.mp4
Testing instructions