Skip to content

Remove unused MiniKiosk from action settings#2138

Draft
soamdesai-tfh wants to merge 2 commits into
mainfrom
codex/remove-unused-minikiosk
Draft

Remove unused MiniKiosk from action settings#2138
soamdesai-tfh wants to merge 2 commits into
mainfrom
codex/remove-unused-minikiosk

Conversation

@soamdesai-tfh

@soamdesai-tfh soamdesai-tfh commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • remove the unreachable embedded MiniKiosk from V2 and V3 action Settings
  • simplify both TryAction views to render the existing integration code directly
  • preserve the full navigable Kiosk route, navigation, and shared Kiosk implementation

Why

Every current TryAction callsite passed enableKiosk={false}, so users could never open the embedded preview. Its static imports still placed IDKit and QR rendering in the Settings client graph.

MiniKiosk was intentionally disabled in #1962 because it used a mock RP signature that World App could not trust. Re-enabling it would require a server-side RP-signing flow.

The production manifest now excludes the runtime IDKit chunk (110.1 KB parsed / 30.3 KB gzip) and react-qr-code chunk (25.9 KB parsed / 9.4 KB gzip) from action Settings. Including deleted route-local code, the bundle-audit estimate is about 144 KB parsed / 41.7 KB gzip removed from initial Settings JS.

User impact

  • code samples remain unchanged
  • the unused view switcher, including its always-selected Code icon, is removed
  • legacy cloud actions still reach Kiosk through the action's Kiosk tab
  • the full Kiosk retains IDKit and QR rendering
  • on-chain Kiosk availability is unchanged

Validation

  • pnpm format:check
  • npx tsc --noEmit
  • npx jest tests/unit lib/schema --maxWorkers=2 --no-cache — 79 suites, 367 tests passed
  • pnpm build using the repository's documented dummy build-time values
  • compiled client-manifest assertions:
    • Settings excludes runtime IDKit and react-qr-code
    • full Kiosk retains runtime IDKit and react-qr-code
    • Profile retains runtime IDKit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant