Skip to content

feat(enclave): run face matching in matches flow - #11

Merged
Takaros999 merged 10 commits into
mainfrom
takis/face-comparison-placeholder
Aug 18, 2026
Merged

feat(enclave): run face matching in matches flow#11
Takaros999 merged 10 commits into
mainfrom
takis/face-comparison-placeholder

Conversation

@Takaros999

@Takaros999 Takaros999 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

This PR:

  • Introduces face-engine our internal engine for running face models, the same one that is used in our mobile apps.
  • Adds a script to download models locally for development from Hugging Face.
  • Adds the embedding comparison logic to the /matches route
  • Adds an e2e test that I run inside a real nitro enclave and verified face engine works and runs

⚠️ This is still a prototype; You have to download models using the script and the face engine configs are placeholder defaults ⚠️

@socket-security

socket-security Bot commented Jul 28, 2026

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@Takaros999
Takaros999 marked this pull request as ready for review July 29, 2026 18:50

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5de9426d50

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/build-enclave-eif.yml
Comment thread secure-enclave/src/face_engine.rs
kilianglas
kilianglas previously approved these changes Aug 4, 2026
@Takaros999
Takaros999 merged commit 14ddf01 into main Aug 18, 2026
14 checks passed
@Takaros999
Takaros999 deleted the takis/face-comparison-placeholder branch August 18, 2026 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants