Skip to content

refactor: migrate verifier client to pontifex - #97

Merged
Takaros999 merged 3 commits into
mainfrom
takis/remove-attested-channel
Sep 5, 2026
Merged

refactor: migrate verifier client to pontifex#97
Takaros999 merged 3 commits into
mainfrom
takis/remove-attested-channel

Conversation

@Takaros999

@Takaros999 Takaros999 commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

PR 3 of 3.

This PR updated the verifier client with the latest API changes and adopts pontifex. It also deletes attested-channel 🪓 .


Note

High Risk
This replaces local attestation and sealed-channel cryptography with an external library and tightens PCR policy, which can break assignments or wire compatibility if Pontifex behavior diverges from the removed crate.

Overview
Removes the in-repo attested-channel crate (Nitro attestation verification and the HPKE match channel) and routes the verifier client and e2e harness through Pontifex for attestation and sealed channels. Workspace/release config drops the published attested-channel package and related crypto workspace dependencies.

The verifier client now builds a Pontifex Verifier from config, verifies assignments via ChannelConsumer::from_attestation using MATCH_CHANNEL_DOMAIN plus separate base64 attestation and public_key fields, and seals/opens match traffic with seal_to_enclave / open_from_enclave. request_assignment and request_match no longer take a clock argument; VerifiedAssignment exposes attestation() and consumer() instead of a public Requester.

Configuration is tighter and Pontifex-shaped: PCR policies must include a nonzero 48-byte PCR0, measurements are 48 bytes with unique indices, allow_debug_measurements is removed, Config::verifier() can fail, and JSON uses deny_unknown_fields with hex PCR serde. Public re-exports shift to Pontifex’s ChannelConsumer and PcrMeasurement.

E2e defaults to the full HTTP client path; optional VERIFIER_E2E_TRANSPORT=vsock keeps a Pontifex vsock match path using the same verified assignment consumer. Client tests were updated for the new APIs and slimmer assignment fixtures.

Reviewed by Cursor Bugbot for commit 1be45df. Bugbot is set up for automated code reviews on this repo. Configure here.

@Takaros999
Takaros999 force-pushed the takis/remove-attested-channel branch from 2048b08 to aabc055 Compare September 4, 2026 21:46
@Takaros999 Takaros999 changed the title refactor: remove the legacy attested-channel crate refactor: migrate verifier client to pontifex Sep 4, 2026
@Takaros999
Takaros999 changed the base branch from takis/pontifex-channel-api to takis/pontifex-host-api September 4, 2026 21:47
@Takaros999
Takaros999 force-pushed the takis/remove-attested-channel branch from aabc055 to c4b1fdc Compare September 4, 2026 21:56
@Takaros999
Takaros999 marked this pull request as ready for review September 4, 2026 22:15
kilianglas
kilianglas previously approved these changes Sep 4, 2026
Comment thread deny.toml Outdated
Comment thread deny.toml Outdated
Comment thread verifier/client/src/config.rs Outdated
@paolodamico

Copy link
Copy Markdown

@codex review

@paolodamico

Copy link
Copy Markdown

cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 1be45df. Configure here.

@Takaros999
Takaros999 disabled the stack merge September 5, 2026 01:09
@Takaros999
Takaros999 force-pushed the takis/remove-attested-channel branch from 1be45df to e5abd20 Compare September 5, 2026 01:10
Base automatically changed from takis/pontifex-host-api to main September 5, 2026 01:11
@Takaros999
Takaros999 force-pushed the takis/remove-attested-channel branch from e5abd20 to 3e63266 Compare September 5, 2026 01:11
@Takaros999
Takaros999 merged commit 6b580bc into main Sep 5, 2026
13 of 14 checks passed
@Takaros999
Takaros999 deleted the takis/remove-attested-channel branch September 5, 2026 01:12
@github-actions github-actions Bot mentioned this pull request Sep 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants