refactor: migrate verifier client to pontifex - #97
Merged
Conversation
Takaros999
force-pushed
the
takis/remove-attested-channel
branch
from
September 4, 2026 21:46
2048b08 to
aabc055
Compare
Takaros999
changed the base branch from
takis/pontifex-channel-api
to
takis/pontifex-host-api
September 4, 2026 21:47
Takaros999
force-pushed
the
takis/remove-attested-channel
branch
from
September 4, 2026 21:56
aabc055 to
c4b1fdc
Compare
Takaros999
marked this pull request as ready for review
September 4, 2026 22:15
kilianglas
previously approved these changes
Sep 4, 2026
paolodamico
reviewed
Sep 4, 2026
Takaros999
force-pushed
the
takis/remove-attested-channel
branch
from
September 4, 2026 23:21
f0f1814 to
1370987
Compare
Takaros999
force-pushed
the
takis/remove-attested-channel
branch
2 times, most recently
from
September 4, 2026 23:58
6f43b9c to
1be45df
Compare
|
@codex review |
|
cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 1be45df. Configure here.
paolodamico
approved these changes
Sep 5, 2026
Takaros999
disabled the stack merge
September 5, 2026 01:09
Takaros999
force-pushed
the
takis/remove-attested-channel
branch
from
September 5, 2026 01:10
1be45df to
e5abd20
Compare
Takaros999
force-pushed
the
takis/remove-attested-channel
branch
from
September 5, 2026 01:11
e5abd20 to
3e63266
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 3 of 3.
This PR updated the verifier client with the latest API changes and adopts pontifex. It also deletes
attested-channel🪓 .Note
High Risk
This replaces local attestation and sealed-channel cryptography with an external library and tightens PCR policy, which can break assignments or wire compatibility if Pontifex behavior diverges from the removed crate.
Overview
Removes the in-repo
attested-channelcrate (Nitro attestation verification and the HPKE match channel) and routes the verifier client and e2e harness through Pontifex for attestation and sealed channels. Workspace/release config drops the publishedattested-channelpackage and related crypto workspace dependencies.The verifier client now builds a Pontifex
Verifierfrom config, verifies assignments viaChannelConsumer::from_attestationusingMATCH_CHANNEL_DOMAINplus separate base64 attestation and public_key fields, and seals/opens match traffic withseal_to_enclave/open_from_enclave.request_assignmentandrequest_matchno longer take a clock argument;VerifiedAssignmentexposesattestation()andconsumer()instead of a publicRequester.Configuration is tighter and Pontifex-shaped: PCR policies must include a nonzero 48-byte PCR0, measurements are 48 bytes with unique indices,
allow_debug_measurementsis removed,Config::verifier()can fail, and JSON usesdeny_unknown_fieldswith hex PCR serde. Public re-exports shift to Pontifex’sChannelConsumerandPcrMeasurement.E2e defaults to the full HTTP client path; optional
VERIFIER_E2E_TRANSPORT=vsockkeeps a Pontifex vsock match path using the same verified assignment consumer. Client tests were updated for the new APIs and slimmer assignment fixtures.Reviewed by Cursor Bugbot for commit 1be45df. Bugbot is set up for automated code reviews on this repo. Configure here.